That way when looking at logs it's clear whether diagnostics are a
result of compile flags mismatch.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM.
Please note the NIT that arguably improves readability.
clang-tools-extra/clangd/tool/Check.cpp | ||
---|---|---|
114–116 | NIT: maybe change the order of arguments and the format string placeholders? log("{1}, {0}!", "world", "Hello"); // vs log("{0}, {1}!", "Hello", "world"); |
NIT: maybe change the order of arguments and the format string placeholders?
it's a bit hard to swap arguments inside one's head when reading the code.