Page MenuHomePhabricator

Validate python packages availability before building ompd gdb-plugin code
Needs ReviewPublic

Authored by Vigneshbalu on Jul 20 2022, 6:13 AM.

Details

Summary

This is a follow up patch to the review: https://reviews.llvm.org/D100185
GDB uses a python interface to access OpenMP runtime through libompd.
This python code depends on packages like "wheel" and "setuptools", so verify the availability of those packages before building gdb-plugin code.

Diff Detail

Event Timeline

Vigneshbalu created this revision.Jul 20 2022, 6:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2022, 6:13 AM
Herald added a subscriber: mgorny. · View Herald Transcript
Vigneshbalu requested review of this revision.Jul 20 2022, 6:13 AM
Herald added a project: Restricted Project. · View Herald Transcript

This patch is validated on Ubuntu 20.04.
I will validate the same in debian and fedora and update.

An alternative approach would be to install the python modules wheels and setuptools into the build directory using pip instead of bailing out.

openmp/libompd/CMakeLists.txt
64

I'm afraid, this will break if locale is not English.