[MemorySSA] Don't create new memory accesses for dbg intrinsics in MemorySSA
AbandonedPublic
Actions

Authored by ChuanqiXu on Jul 20 2022, 1:55 AM.

Details

Reviewers

nikic
fhahn
asbirlea

Summary

After we landed https://reviews.llvm.org/D127383, the compiler may crash at: https://github.com/llvm/llvm-project/blob/051738b08cf5e39fd274dd379147d1c19e2b5b20/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp#L687-L691.

This is because the dbg intrinsics are readnone originally and the MemorySSA would refuse to create a new memory access at https://github.com/llvm/llvm-project/blob/051738b08cf5e39fd274dd379147d1c19e2b5b20/llvm/lib/Analysis/MemorySSA.cpp#L1830-L1831

But after D127383, it wouldn't be true for the dbg intrinsics in presplit coroutine. So here is the crash.

Diff Detail

Unit TestsFailed
View All

	Time	Test
	60,130 ms	x64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::scariness_score_test.cpp Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -shared-libasan -O0 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/scariness_score_test.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxDynamicConfig/TestCases/Output/scariness_score_test.cpp.tmp
	60,130 ms	x64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -O0 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/scariness_score_test.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxConfig/TestCases/Output/scariness_score_test.cpp.tmp

Event Timeline

ChuanqiXu created this revision.Jul 20 2022, 1:55 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2022, 1:55 AM

Herald added subscribers: asbirlea, george.burgess.iv, hiraditya. · View Herald Transcript

ChuanqiXu requested review of this revision.Jul 20 2022, 1:55 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2022, 1:55 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

ChuanqiXu mentioned this in D127383: Don't treat readnone call in presplit coroutine as not access memory.Jul 20 2022, 2:04 AM

ChuanqiXu added a child revision: D127383: Don't treat readnone call in presplit coroutine as not access memory.

Harbormaster completed remote builds in B176452: Diff 446080.Jul 20 2022, 2:44 AM

ChuanqiXu retitled this revision from [DRAFT] Don't create new memory accesses for dbg intrinsics in MemorySSA to Don't create new memory accesses for dbg intrinsics in MemorySSA.Jul 20 2022, 2:49 AM

ChuanqiXu added a reviewer: nikic.

ChuanqiXu retitled this revision from Don't create new memory accesses for dbg intrinsics in MemorySSA to [NFC] Don't create new memory accesses for dbg intrinsics in MemorySSA.Jul 20 2022, 2:52 AM

ChuanqiXu edited the summary of this revision. (Show Details)

ChuanqiXu mentioned this in D130155: [DeadStoreElimination] Handle null accessing.Jul 21 2022, 10:36 PM