[BOLT] Remove --allow-stripped option

[nhuhuan]

Summary

AllowStripped has not been used in BOLT.
This option is replaced by actively detecting stripped binary.

Test Plan:

[maksfb]

I don't think --allow-stripped option is used anymore and it's okay to remove it. But the option changes the behavior for handling the error case and hence the change is not NFC. Could you retitle to "[BOLT] Remove --allow-stripped option"?

bolt/lib/Rewrite/RewriteInstance.cpp

2814

[nhuhuan]

Remove trailing dot

[Amir]

Accepting per Maksim's comment that it's OK to remove the option.

bolt/lib/Rewrite/RewriteInstance.cpp

static cl::opt<bool> ForceToDataRelocations(
     cl::Hidden, cl::cat(BoltCategory));
 
 cl::opt<std::string>
     BoltID("bolt-id",
            cl::desc("add any string to tag this execution in the "
                     "output binary via bolt info section"),
            cl::cat(BoltCategory));
 
-cl::opt<bool>
-AllowStripped("allow-stripped",
-  cl::desc("allow processing of stripped binaries"),
-  cl::Hidden,
-  cl::cat(BoltCategory));
-
 cl::opt<bool> DumpDotAll(
     "dump-dot-all",
     cl::desc("dump function CFGs to graphviz format after each stage;"
              "enable '-print-loops' for color-coded blocks"),
     cl::Hidden, cl::cat(BoltCategory));
 
 static cl::list<std::string>
 ForceFunctionNames("funcs",
if (BAT->enabledFor(InputFile)) {
     outs() << "BOLT-INFO: profile collection done on a binary already "
               "processed by BOLT\n";
     ProfileReader->setBAT(&*BAT);
   }
 
   if (Error E = ProfileReader->preprocessProfile(*BC.get()))
     report_error("cannot pre-process profile", std::move(E));
 
-  if (!BC->hasSymbolsWithFileName() && ProfileReader->hasLocalsWithFileName() &&
-      !opts::AllowStripped) {
+  if (!BC->hasSymbolsWithFileName() && ProfileReader->hasLocalsWithFileName()) {
     errs() << "BOLT-ERROR: input binary does not have local file symbols "
               "but profile data includes function names with embedded file "
               "names. It appears that the input binary was stripped while a "
-              "profiled binary was not. If you know what you are doing and "
-              "wish to proceed, use -allow-stripped option.\n";
+              "profiled binary was not\n";
     exit(1);
   }
 }
 
 void RewriteInstance::processProfileDataPreCFG() {
   if (!ProfileReader)
     return;