Page MenuHomePhabricator

nhuhuan (Huan Nguyen)
User

Projects

User does not belong to any projects.

User Details

User Since
May 26 2022, 5:03 PM (10 w, 6 d)

Recent Activity

Fri, Aug 5

nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Update parent-fragment relation when adding parent to jump table

Fri, Aug 5, 6:24 PM · Restricted Project, Restricted Project
nhuhuan retitled D129974: [BOLT] Improve jump table entry validation for split jump table from [BOLT] Support split jump table to [BOLT] Improve jump table entry validation for split jump table.
Fri, Aug 5, 6:18 PM · Restricted Project, Restricted Project
nhuhuan retitled D129974: [BOLT] Improve jump table entry validation for split jump table from [BOLT] Support split jump table for stripped binaries to [BOLT] Support split jump table.
Fri, Aug 5, 6:15 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D131283: [BOLT] Disable -lite when split function is present.

Remove trailing dots.

Fri, Aug 5, 4:21 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D131283: [BOLT] Disable -lite when split function is present.

Check before issue the warning.

Fri, Aug 5, 3:26 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D131283: [BOLT] Disable -lite when split function is present.

Clang-formatted.

Fri, Aug 5, 2:49 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D131283: [BOLT] Disable -lite when split function is present.

Avoid printing duplicate warnings.

Fri, Aug 5, 2:47 PM · Restricted Project, Restricted Project
nhuhuan requested review of D131283: [BOLT] Disable -lite when split function is present.
Fri, Aug 5, 12:52 PM · Restricted Project, Restricted Project

Thu, Aug 4

nhuhuan added inline comments to D131139: [BOLT] Fix issue related to missing symbol name.
Thu, Aug 4, 2:20 PM · Restricted Project, Restricted Project

Wed, Aug 3

nhuhuan updated the diff for D131139: [BOLT] Fix issue related to missing symbol name.

Clang-formatted

Wed, Aug 3, 10:13 PM · Restricted Project, Restricted Project
nhuhuan requested review of D131139: [BOLT] Fix issue related to missing symbol name.
Wed, Aug 3, 9:43 PM · Restricted Project, Restricted Project

Tue, Aug 2

nhuhuan updated the diff for D130943: [BOLT] Support jump table entry to sibling's builtin_unreachable.

Support builtin_unreachable when another function is placed
after the sibling fragment

Tue, Aug 2, 4:34 PM · Restricted Project, Restricted Project

Mon, Aug 1

nhuhuan requested review of D130943: [BOLT] Support jump table entry to sibling's builtin_unreachable.
Mon, Aug 1, 2:30 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130815: [BOLT] Handle unclaimed PC data relocation related to jump table.

Fix misidentifying jump table entries to be ignored

Mon, Aug 1, 12:53 AM · Restricted Project, Restricted Project

Sun, Jul 31

nhuhuan updated the diff for D130815: [BOLT] Handle unclaimed PC data relocation related to jump table.

Fixed the acceptable range

Sun, Jul 31, 9:31 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130815: [BOLT] Handle unclaimed PC data relocation related to jump table.

Improve the acceptable range of potental jump table entry

Sun, Jul 31, 1:26 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130815: [BOLT] Handle unclaimed PC data relocation related to jump table.

Improve checks to reduce unnecessary ignoring of functions

Sun, Jul 31, 12:17 AM · Restricted Project, Restricted Project

Fri, Jul 29

nhuhuan requested review of D130815: [BOLT] Handle unclaimed PC data relocation related to jump table.
Fri, Jul 29, 7:38 PM · Restricted Project, Restricted Project
nhuhuan requested review of D130751: [BOLT] Postprocess entry points after disassembly.
Fri, Jul 29, 2:34 AM · Restricted Project, Restricted Project

Thu, Jul 28

nhuhuan retitled D130431: [BOLT] Ignore functions accessing false positive jump tables from [BOLT] Handle false positive jump tables to [BOLT] Ignore functions accessing false positive jump tables.
Thu, Jul 28, 11:08 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130673: [BOLT] Handle jump tables that point to skipped functions.

Rebase.

Thu, Jul 28, 10:23 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130431: [BOLT] Ignore functions accessing false positive jump tables.

Rebase.

Thu, Jul 28, 10:20 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Rebase.

Thu, Jul 28, 10:11 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130071: [BOLT] Adapted policy checks for stripped binaries.

Clarify that it will not affect the correctness in processing nonstripped
binaries.

Thu, Jul 28, 9:10 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130071: [BOLT] Adapted policy checks for stripped binaries.

Updated comment

Thu, Jul 28, 5:42 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130034: [BOLT] Add BinaryContext::IsStripped.

Clang-formatted.

Thu, Jul 28, 2:45 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130034: [BOLT] Add BinaryContext::IsStripped.

Address feedbacks.

Thu, Jul 28, 2:30 PM · Restricted Project, Restricted Project

Wed, Jul 27

nhuhuan updated the diff for D130431: [BOLT] Ignore functions accessing false positive jump tables.

Added the manual test back

Wed, Jul 27, 4:35 PM · Restricted Project, Restricted Project
nhuhuan requested review of D130673: [BOLT] Handle jump tables that point to skipped functions.
Wed, Jul 27, 4:30 PM · Restricted Project, Restricted Project
nhuhuan retitled D130431: [BOLT] Ignore functions accessing false positive jump tables from [BOLT] Fix split jump table issues to [BOLT] Handle false positive jump tables.
Wed, Jul 27, 4:07 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130431: [BOLT] Ignore functions accessing false positive jump tables.

Add description for AbortedJTs

Wed, Jul 27, 4:03 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130431: [BOLT] Ignore functions accessing false positive jump tables.

Split this diff into a few diffs.

Wed, Jul 27, 4:00 PM · Restricted Project, Restricted Project
nhuhuan added inline comments to D130072: [BOLT] Update labels for split landing pad.
Wed, Jul 27, 3:00 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130072: [BOLT] Update labels for split landing pad.

Address feedbacks

Wed, Jul 27, 3:00 PM · Restricted Project, Restricted Project
nhuhuan requested review of D130663: [BOLT] Update sibling relationship from LSDA Section.
Wed, Jul 27, 1:25 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Clang-formatted.

Wed, Jul 27, 3:30 AM · Restricted Project, Restricted Project
nhuhuan requested review of D130617: [BOLT] Update split landing pad check for stripped binaries.
Wed, Jul 27, 2:27 AM · Restricted Project, Restricted Project
nhuhuan retitled D130072: [BOLT] Update labels for split landing pad from [BOLT] Support split landing pad for stripped binaries to [BOLT] Update labels for split landing pad.
Wed, Jul 27, 1:20 AM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130072: [BOLT] Update labels for split landing pad.

Split this diff into a few diffs.

Wed, Jul 27, 1:19 AM · Restricted Project, Restricted Project

Tue, Jul 26

nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Refine comments. Improve implementation for isValidJumpTableEntry.

Tue, Jul 26, 9:22 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Incorporate debugging messages into isValidJumpTableEntry.
An entry failing isValidJumpTableEntry does not mean the
jump table is invalid. Suppose we have a true jump table
base, it means we found the bounds.

Tue, Jul 26, 2:26 PM · Restricted Project, Restricted Project
nhuhuan added inline comments to D130072: [BOLT] Update labels for split landing pad.
Tue, Jul 26, 12:44 PM · Restricted Project, Restricted Project
nhuhuan added a comment to D130072: [BOLT] Update labels for split landing pad.

I'm also curious if this adds runtime overhead by parsing LSDA two times per function. Can we measure that using a large binary as input?

Tue, Jul 26, 11:51 AM · Restricted Project, Restricted Project
nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Update comment.

Tue, Jul 26, 12:39 AM · Restricted Project, Restricted Project

Mon, Jul 25

nhuhuan updated the diff for D130036: [BOLT] Remove --allow-stripped option.

Remove trailing dot

Mon, Jul 25, 11:28 PM · Restricted Project, Restricted Project
nhuhuan retitled D130036: [BOLT] Remove --allow-stripped option from [BOLT][NFC] Remove opts::AllowStripped to [BOLT] Remove --allow-stripped option.
Mon, Jul 25, 11:22 PM · Restricted Project, Restricted Project
nhuhuan updated the summary of D129974: [BOLT] Improve jump table entry validation for split jump table.
Mon, Jul 25, 10:11 PM · Restricted Project, Restricted Project
nhuhuan updated the summary of D129974: [BOLT] Improve jump table entry validation for split jump table.
Mon, Jul 25, 10:08 PM · Restricted Project, Restricted Project
nhuhuan updated the summary of D129974: [BOLT] Improve jump table entry validation for split jump table.
Mon, Jul 25, 10:06 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Address Maksim's feedback.

Mon, Jul 25, 9:58 PM · Restricted Project, Restricted Project

Sat, Jul 23

nhuhuan updated the summary of D130431: [BOLT] Ignore functions accessing false positive jump tables.
Sat, Jul 23, 2:25 PM · Restricted Project, Restricted Project
nhuhuan updated the summary of D129974: [BOLT] Improve jump table entry validation for split jump table.
Sat, Jul 23, 2:20 PM · Restricted Project, Restricted Project
nhuhuan requested review of D130431: [BOLT] Ignore functions accessing false positive jump tables.
Sat, Jul 23, 2:20 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Revert. Move jump table fixes to another diff.

Sat, Jul 23, 12:48 PM · Restricted Project, Restricted Project

Thu, Jul 21

nhuhuan updated the summary of D129974: [BOLT] Improve jump table entry validation for split jump table.
Thu, Jul 21, 2:44 AM · Restricted Project, Restricted Project
nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Fix an issue where split jump table targets are marked as
secondary entry points, but they skipped instruction bounds
check in postProcessEntryPoints().

Thu, Jul 21, 2:36 AM · Restricted Project, Restricted Project

Wed, Jul 20

nhuhuan updated the diff for D130073: [BOLT] Handle broken .dynsym in stripped binaries.

Simplified test.

Wed, Jul 20, 4:40 PM · Restricted Project, Restricted Project

Tue, Jul 19

nhuhuan updated the diff for D130073: [BOLT] Handle broken .dynsym in stripped binaries.

Update test case.

Tue, Jul 19, 3:12 PM · Restricted Project, Restricted Project
nhuhuan updated the summary of D129974: [BOLT] Improve jump table entry validation for split jump table.
Tue, Jul 19, 10:31 AM · Restricted Project, Restricted Project
nhuhuan retitled D129974: [BOLT] Improve jump table entry validation for split jump table from [BOLT] Support split function in stripped binaries to [BOLT] Support split jump table for stripped binaries.
Tue, Jul 19, 4:17 AM · Restricted Project, Restricted Project
nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Split into several diffs. This diff is about supporting
split jump table in in stripped binaries.

Tue, Jul 19, 4:06 AM · Restricted Project, Restricted Project
nhuhuan requested review of D130073: [BOLT] Handle broken .dynsym in stripped binaries.
Tue, Jul 19, 3:50 AM · Restricted Project, Restricted Project
nhuhuan updated the summary of D130072: [BOLT] Update labels for split landing pad.
Tue, Jul 19, 3:37 AM · Restricted Project, Restricted Project
nhuhuan updated the summary of D130072: [BOLT] Update labels for split landing pad.
Tue, Jul 19, 3:30 AM · Restricted Project, Restricted Project
nhuhuan updated the summary of D130072: [BOLT] Update labels for split landing pad.
Tue, Jul 19, 3:28 AM · Restricted Project, Restricted Project
nhuhuan updated the summary of D130072: [BOLT] Update labels for split landing pad.
Tue, Jul 19, 3:27 AM · Restricted Project, Restricted Project
nhuhuan updated the summary of D130072: [BOLT] Update labels for split landing pad.
Tue, Jul 19, 3:26 AM · Restricted Project, Restricted Project
nhuhuan requested review of D130072: [BOLT] Update labels for split landing pad.
Tue, Jul 19, 3:25 AM · Restricted Project, Restricted Project
nhuhuan requested review of D130071: [BOLT] Adapted policy checks for stripped binaries.
Tue, Jul 19, 2:52 AM · Restricted Project, Restricted Project
nhuhuan retitled D130034: [BOLT] Add BinaryContext::IsStripped from [BOLT][NFC] Add BinaryContext::IsStripped to [BOLT] Add BinaryContext::IsStripped.
Tue, Jul 19, 2:30 AM · Restricted Project, Restricted Project
nhuhuan updated the diff for D130034: [BOLT] Add BinaryContext::IsStripped.

Print strip status. Add a test.

Tue, Jul 19, 2:28 AM · Restricted Project, Restricted Project

Mon, Jul 18

nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Add description for the test.

Mon, Jul 18, 12:49 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Based on top of D130034 and D130036

Mon, Jul 18, 12:43 PM · Restricted Project, Restricted Project
nhuhuan requested review of D130036: [BOLT] Remove --allow-stripped option.
Mon, Jul 18, 12:34 PM · Restricted Project, Restricted Project
nhuhuan requested review of D130034: [BOLT] Add BinaryContext::IsStripped.
Mon, Jul 18, 12:02 PM · Restricted Project, Restricted Project

Sun, Jul 17

nhuhuan updated the diff for D129974: [BOLT] Improve jump table entry validation for split jump table.

Separate the removal of AllowStripped into another diff.

Sun, Jul 17, 7:49 PM · Restricted Project, Restricted Project
nhuhuan updated the summary of D129974: [BOLT] Improve jump table entry validation for split jump table.
Sun, Jul 17, 2:27 PM · Restricted Project, Restricted Project
nhuhuan updated the summary of D129974: [BOLT] Improve jump table entry validation for split jump table.
Sun, Jul 17, 2:26 PM · Restricted Project, Restricted Project
nhuhuan updated the summary of D129974: [BOLT] Improve jump table entry validation for split jump table.
Sun, Jul 17, 2:22 PM · Restricted Project, Restricted Project
nhuhuan requested review of D129974: [BOLT] Improve jump table entry validation for split jump table.
Sun, Jul 17, 2:16 PM · Restricted Project, Restricted Project

Thu, Jul 14

nhuhuan committed rGae563c914655: [BOLT] Support split landing pad (authored by nhuhuan).
[BOLT] Support split landing pad
Thu, Jul 14, 6:11 PM · Restricted Project
nhuhuan closed D128561: [BOLT] Support split landing pad.
Thu, Jul 14, 6:10 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D128561: [BOLT] Support split landing pad.

Rebase and fix conflicts.

Thu, Jul 14, 2:24 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D128561: [BOLT] Support split landing pad.

Rebase

Thu, Jul 14, 1:18 AM · Restricted Project, Restricted Project
nhuhuan updated the diff for D128561: [BOLT] Support split landing pad.

Rebase

Thu, Jul 14, 12:45 AM · Restricted Project, Restricted Project

Wed, Jul 13

nhuhuan committed rG05523dc32d8c: [BOLT] Support multiple parents for split jump table (authored by nhuhuan).
[BOLT] Support multiple parents for split jump table
Wed, Jul 13, 11:38 PM · Restricted Project
nhuhuan closed D128474: [BOLT] Support multiple parents for split jump table.
Wed, Jul 13, 11:38 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D128474: [BOLT] Support multiple parents for split jump table.

Rebase

Wed, Jul 13, 3:13 PM · Restricted Project, Restricted Project

Jul 4 2022

nhuhuan updated the diff for D128561: [BOLT] Support split landing pad.

Fix incorrect condition in assertion

Jul 4 2022, 5:23 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D128561: [BOLT] Support split landing pad.

In this update:

  • Fix a bug related to landing pad in builtin_unreachable.
  • Add an assert that landing pad must be in an identified function.
Jul 4 2022, 4:42 PM · Restricted Project, Restricted Project
nhuhuan added inline comments to D128561: [BOLT] Support split landing pad.
Jul 4 2022, 2:43 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D128561: [BOLT] Support split landing pad.

In this update:

  • Support DW_EH_PE_absptr encoding.
  • Add comments on how this test was written.
Jul 4 2022, 2:41 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D128474: [BOLT] Support multiple parents for split jump table.

Fix bugs:
(a) missing builtin_unreachable jump table targets
(b) incorrect jump table duplication

Jul 4 2022, 11:53 AM · Restricted Project, Restricted Project

Jun 29 2022

nhuhuan updated the diff for D128474: [BOLT] Support multiple parents for split jump table.

Address feedbacks.

Jun 29 2022, 12:06 AM · Restricted Project, Restricted Project

Jun 28 2022

nhuhuan updated the diff for D128474: [BOLT] Support multiple parents for split jump table.

Clang-formatted.

Jun 28 2022, 9:06 PM · Restricted Project, Restricted Project
nhuhuan updated the summary of D128474: [BOLT] Support multiple parents for split jump table.
Jun 28 2022, 9:00 PM · Restricted Project, Restricted Project
nhuhuan updated the diff for D128474: [BOLT] Support multiple parents for split jump table.

Update how jump table entries are generated. Allow buildCFG to operate
on non-simple fragments. Address feedbacks.

Jun 28 2022, 8:58 PM · Restricted Project, Restricted Project
nhuhuan added inline comments to D128474: [BOLT] Support multiple parents for split jump table.
Jun 28 2022, 8:23 PM · Restricted Project, Restricted Project

Jun 27 2022

nhuhuan updated the diff for D128474: [BOLT] Support multiple parents for split jump table.

Address the feedbacks.

Jun 27 2022, 11:24 AM · Restricted Project, Restricted Project

Jun 24 2022

nhuhuan retitled D128561: [BOLT] Support split landing pad from [BOTL] Support split landing pad to [BOLT] Support split landing pad.
Jun 24 2022, 6:09 PM · Restricted Project, Restricted Project