This is an archive of the discontinued LLVM Phabricator instance.

Differential D129976

[libc++] Add clang-tidy for the tests
ClosedPublic

Authored by philnik on Jul 17 2022, 5:01 PM.

Details

Reviewers
ldionne
Mordante
var-const
huixie90
Group Reviewers
Restricted Project
Commits
rG20d30f709b9a: [libc++] Add clang-tidy for the tests

Diff Detail

Event Timeline

philnik created this revision.Jul 17 2022, 5:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2022, 5:01 PM
philnik requested review of this revision.Jul 17 2022, 5:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2022, 5:01 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, aheejin. · View Herald Transcript
Harbormaster completed remote builds in B175929: Diff 445361.Jul 17 2022, 7:36 PM
huixie90 accepted this revision.Jul 18 2022, 1:21 AM

thanks for the update

Mordante accepted this revision.Jul 18 2022, 9:29 AM

This means no changes to the test were required?

LGTM! But please wait a few day before landing to give other reviews time to look at it.

This revision is now accepted and ready to land.Jul 18 2022, 9:29 AM
philnik added a comment.Jul 18 2022, 1:34 PM
In D129976#3660165, @Mordante wrote:

This means no changes to the test were required?

LGTM! But please wait a few day before landing to give other reviews time to look at it.

This is just to avoid sprinkling the tests with useless warnings everywhere. The clang-tidy on the tests isn't actually enforced.

Mordante added a comment.Jul 19 2022, 12:59 PM
In D129976#3660847, @philnik wrote:
In D129976#3660165, @Mordante wrote:

This means no changes to the test were required?

LGTM! But please wait a few day before landing to give other reviews time to look at it.

This is just to avoid sprinkling the tests with useless warnings everywhere. The clang-tidy on the tests isn't actually enforced.

In that case feel free to land it. We can reevaluate the setting when in the patch that enforces it.

Closed by commit rG20d30f709b9a: [libc++] Add clang-tidy for the tests (authored by philnik). · Explain WhyJul 20 2022, 2:27 AM
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG20d30f709b9a: [libc++] Add clang-tidy for the tests.

Revision Contents

PathSize
libcxx/
test/
5 lines
libcxx/
2 lines

Diff 446087

libcxx/test/.clang-tidy

  • This file was added.
InheritParentConfig: true
CheckOptions:
- key: readability-identifier-naming.ParameterPrefix
value: ""

libcxx/test/libcxx/clang_tidy.sh.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// REQUIRES: has-clang-tidy // REQUIRES: has-clang-tidy
// TODO: run clang-tidy with modules enabled once they are supported // TODO: run clang-tidy with modules enabled once they are supported
// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wweak-vtables -Wno-unknown-warning-option %{compile_flags} -fno-modules // RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* --config-file=%S/../../.clang-tidy -- -Wweak-vtables -Wno-unknown-warning-option %{compile_flags} -fno-modules
// -Wno-unknown-warning-option tells clang-tidy to ignore '-W' command-line arguments that it doesn't know. // -Wno-unknown-warning-option tells clang-tidy to ignore '-W' command-line arguments that it doesn't know.
// There are some GCC-specific ones where clang-tidy would warn otherwise. // There are some GCC-specific ones where clang-tidy would warn otherwise.
// Prevent <ext/hash_map> from generating deprecated warnings for this test. // Prevent <ext/hash_map> from generating deprecated warnings for this test.
#if defined(__DEPRECATED) #if defined(__DEPRECATED)
# undef __DEPRECATED # undef __DEPRECATED
#endif #endif
▲ Show 20 Lines • Show All 249 Lines • Show Last 20 Lines