Page MenuHomePhabricator

[libc++] Add clang-tidy for the tests
ClosedPublic

Authored by philnik on Jul 17 2022, 5:01 PM.

Details

Diff Detail

Event Timeline

philnik created this revision.Jul 17 2022, 5:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2022, 5:01 PM
philnik requested review of this revision.Jul 17 2022, 5:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2022, 5:01 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
huixie90 accepted this revision.Jul 18 2022, 1:21 AM

thanks for the update

Mordante accepted this revision.Jul 18 2022, 9:29 AM

This means no changes to the test were required?

LGTM! But please wait a few day before landing to give other reviews time to look at it.

This revision is now accepted and ready to land.Jul 18 2022, 9:29 AM

This means no changes to the test were required?

LGTM! But please wait a few day before landing to give other reviews time to look at it.

This is just to avoid sprinkling the tests with useless warnings everywhere. The clang-tidy on the tests isn't actually enforced.

This means no changes to the test were required?

LGTM! But please wait a few day before landing to give other reviews time to look at it.

This is just to avoid sprinkling the tests with useless warnings everywhere. The clang-tidy on the tests isn't actually enforced.

In that case feel free to land it. We can reevaluate the setting when in the patch that enforces it.

This revision was automatically updated to reflect the committed changes.