This is an archive of the discontinued LLVM Phabricator instance.

Differential D129913

[mlir] remove unnecessary statements in test
ClosedPublic

Authored by ashay-github on Jul 15 2022, 5:55 PM.

Details

Reviewers
rriddle
dcaballe
Commits
rG179588ea3951: [mlir] remove unnecessary statements in test
Summary

A previous commit (f2b94bd) added some unnecessary statements that
dereferenced operations only to get the operations back. This patch
removes the unnecessary statements.

Diff Detail

Event Timeline

ashay-github created this revision.Jul 15 2022, 5:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2022, 5:55 PM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 17 others. · View Herald Transcript
ashay-github requested review of this revision.Jul 15 2022, 5:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2022, 5:55 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle accepted this revision.EditedJul 15 2022, 5:56 PM

Thanks!

This revision is now accepted and ready to land.Jul 15 2022, 5:56 PM
ashay-github mentioned this in D129718: [mlir] check whether region and block visitors are interrupted.Jul 15 2022, 5:57 PM
Harbormaster completed remote builds in B175772: Diff 445164.Jul 15 2022, 6:13 PM
Closed by commit rG179588ea3951: [mlir] remove unnecessary statements in test (authored by • ashay). · Explain WhyJul 15 2022, 6:57 PM
This revision was automatically updated to reflect the committed changes.
• ashay added a commit: rG179588ea3951: [mlir] remove unnecessary statements in test.

Revision Contents

PathSize
mlir/
test/
lib/
IR/
15 lines

Diff 445164

mlir/test/lib/IR/TestVisitorsGeneric.cpp

Show First 20 Lines • Show All 125 Lines • ▼ Show 20 Lines StringRef getDescription() const final {
return "Test generic IR visitors with interrupts, starting with Blocks."; return "Test generic IR visitors with interrupts, starting with Blocks.";
} }
void runOnOperation() override { void runOnOperation() override {
int stepNo = 0; int stepNo = 0;
auto walker = [&](Block *block) { auto walker = [&](Block *block) {
for (Operation &op : *block) for (Operation &op : *block)
for (OpResult result : op.getResults()) if (op.getAttrOfType<BoolAttr>("interrupt"))
if (Operation *definingOp = result.getDefiningOp())
if (definingOp->getAttrOfType<BoolAttr>("interrupt"))
return WalkResult::interrupt(); return WalkResult::interrupt();
llvm::outs() << "step " << stepNo++ << "\n"; llvm::outs() << "step " << stepNo++ << "\n";
return WalkResult::advance(); return WalkResult::advance();
}; };
auto result = getOperation()->walk(walker); auto result = getOperation()->walk(walker);
if (result.wasInterrupted()) if (result.wasInterrupted())
llvm::outs() << "step " << stepNo++ << " walk was interrupted\n"; llvm::outs() << "step " << stepNo++ << " walk was interrupted\n";
Show All 12 Linesstruct TestGenericIRRegionVisitorInterruptPass
StringRef getDescription() const final { StringRef getDescription() const final {
return "Test generic IR visitors with interrupts, starting with Regions."; return "Test generic IR visitors with interrupts, starting with Regions.";
} }
void runOnOperation() override { void runOnOperation() override {
int stepNo = 0; int stepNo = 0;
auto walker = [&](Region *region) { auto walker = [&](Region *region) {
for (Block &block : *region) for (Operation &op : region->getOps())
for (Operation &op : block) if (op.getAttrOfType<BoolAttr>("interrupt"))
for (OpResult result : op.getResults())
if (Operation *definingOp = result.getDefiningOp())
if (definingOp->getAttrOfType<BoolAttr>("interrupt"))
return WalkResult::interrupt(); return WalkResult::interrupt();
llvm::outs() << "step " << stepNo++ << "\n"; llvm::outs() << "step " << stepNo++ << "\n";
return WalkResult::advance(); return WalkResult::advance();
}; };
auto result = getOperation()->walk(walker); auto result = getOperation()->walk(walker);
if (result.wasInterrupted()) if (result.wasInterrupted())
llvm::outs() << "step " << stepNo++ << " walk was interrupted\n"; llvm::outs() << "step " << stepNo++ << " walk was interrupted\n";
Show All 16 Lines