Page MenuHomePhabricator

ashay-github (Ashay Rane)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2022, 9:10 PM (9 w, 5 d)

Recent Activity

Thu, Jun 2

ashay-github updated the diff for D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.

Place comment in the assert message

Thu, Jun 2, 9:33 AM · Restricted Project, Restricted Project

Tue, May 31

ashay-github added inline comments to D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.
Tue, May 31, 10:29 AM · Restricted Project, Restricted Project
ashay-github updated the diff for D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.

Ensure that null stride value is never used

Tue, May 31, 10:29 AM · Restricted Project, Restricted Project

Mon, May 30

ashay-github added inline comments to D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.
Mon, May 30, 5:57 PM · Restricted Project, Restricted Project
ashay-github updated the diff for D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.

Now using regular if instead of a ternary statement for better readability

Mon, May 30, 5:56 PM · Restricted Project, Restricted Project

Sat, May 28

ashay-github added inline comments to D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.
Sat, May 28, 5:46 PM · Restricted Project, Restricted Project
ashay-github requested review of D126604: [mlir] translate memref.reshape with static shapes but dynamic dims.
Sat, May 28, 5:41 PM · Restricted Project, Restricted Project

May 12 2022

ashay-github updated the diff for D125039: [mlir] translate memref.reshape ops that have static shapes.

dropping element count in SmallVector usage

May 12 2022, 10:31 AM · Restricted Project, Restricted Project

May 10 2022

ashay-github added a comment to D125039: [mlir] translate memref.reshape ops that have static shapes.

Thanks @cathyzhyi! I added a check for !isStaticStrideOrOffset(offset) as well.

May 10 2022, 5:34 PM · Restricted Project, Restricted Project
ashay-github updated the diff for D125039: [mlir] translate memref.reshape ops that have static shapes.

check for dynamic offset

May 10 2022, 5:32 PM · Restricted Project, Restricted Project
ashay-github added a comment to D125039: [mlir] translate memref.reshape ops that have static shapes.

Thanks @cathyzhyi! I've updated the code accordingly, but please let me know if I still got it wrong. Thanks!

May 10 2022, 10:44 AM · Restricted Project, Restricted Project
ashay-github updated the diff for D125039: [mlir] translate memref.reshape ops that have static shapes.

check for static strides and offsets, otherwise return failure

May 10 2022, 10:40 AM · Restricted Project, Restricted Project

May 9 2022

ashay-github requested review of D125251: [mlir] Fail early if AnalysisState::getBuffer() returns failure.
May 9 2022, 11:27 AM · Restricted Project, Restricted Project
ashay-github added a comment to D125039: [mlir] translate memref.reshape ops that have static shapes.

Thanks for the suggestion. I've updated the code and test to set the offset, stride, and size. PTAL.

May 9 2022, 7:18 AM · Restricted Project, Restricted Project
ashay-github added a comment to D125031: [mlir] Add translation from tensor.reshape to memref.reshape.

Thanks @springerm! Could you commit the change please? I don't yet have write access to the repo.

May 9 2022, 7:16 AM · Restricted Project, Restricted Project

May 6 2022

ashay-github updated the diff for D125039: [mlir] translate memref.reshape ops that have static shapes.

set stride, offset, and size attributes of MemRefDescriptor

May 6 2022, 10:17 AM · Restricted Project, Restricted Project
ashay-github added a comment to D125031: [mlir] Add translation from tensor.reshape to memref.reshape.

Thanks! Fixed the code as per the suggestions. PTAL.

May 6 2022, 9:32 AM · Restricted Project, Restricted Project
ashay-github updated the diff for D125031: [mlir] Add translation from tensor.reshape to memref.reshape.

This patch changes the bufferizesToMemoryRead() method so that it returns true
for the shape operand. It also makes bufferize() return false if
BufferizationState::getBuffer() returns a failure.

May 6 2022, 9:30 AM · Restricted Project, Restricted Project

May 5 2022

ashay-github requested review of D125039: [mlir] translate memref.reshape ops that have static shapes.
May 5 2022, 1:49 PM · Restricted Project, Restricted Project
ashay-github requested review of D125031: [mlir] Add translation from tensor.reshape to memref.reshape.
May 5 2022, 11:50 AM · Restricted Project, Restricted Project

Apr 19 2022

ashay-github added a comment to D123981: [MLIR] Add function to create BFloat16 array attribute.

@stellaraccident Thanks for approving. I do not have commit access yet. Could you (or someone) commit this for now please? Thanks!

Apr 19 2022, 10:46 AM · Restricted Project, Restricted Project

Apr 18 2022

ashay-github requested review of D123981: [MLIR] Add function to create BFloat16 array attribute.
Apr 18 2022, 9:34 PM · Restricted Project, Restricted Project