[AMDGPU][MC][NFC] Remove unnecessary code

[dp]

Summary

validateCoherencyBits is called twice.

[dp]

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

4611

Coherency bits have already been validated here.

[foad]

Looks obvious.

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

if (!validateSMEMOffset(Inst, Operands)) {
     return false;
   }
   if (!validateMAIAccWrite(Inst, Operands)) {
     return false;
   }
   if (!validateMFMA(Inst, Operands)) {
     return false;
   }
   if (!validateCoherencyBits(Inst, Operands, IDLoc)) {
     return false;
   }
 
   if (!validateAGPRLdSt(Inst)) {
     Error(IDLoc, getFeatureBits()[AMDGPU::FeatureGFX90AInsts]
     ? "invalid register class: data and dst should be all VGPR or AGPR"
     : "invalid register class: agpr loads and stores not supported on this GPU"
     );
bool AMDGPUAsmParser::validateInstruction(const MCInst &Inst,
   if (!validateBLGP(Inst, Operands)) {
     return false;
   }
 
   if (!validateDivScale(Inst)) {
     Error(IDLoc, "ABS not allowed in VOP3B instructions");
     return false;
   }
-  if (!validateCoherencyBits(Inst, Operands, IDLoc)) {
-    return false;
-  }
   if (!validateExeczVcczOperands(Operands)) {
     return false;
   }
 
   if (!validateFlatLdsDMA(Inst, Operands, IDLoc)) {
     return false;
   }