[libc++][ranges] implement std::ranges::set_union
Details
Details
- Reviewers
var-const philnik jdoerfert - Group Reviewers
Restricted Project - Commits
- rG3151b95dad40: [libc++][ranges] implement `std::ranges::set_union`
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM with very minor nits. Thanks!
| libcxx/include/__algorithm/set_union.h | ||
|---|---|---|
| 63–78 | If you're already refactoring this line, might as well use _LIBCPP_HIDE_FROM_ABI instead of _LIBCPP_INLINE_VISIBILITY. | |
| 71 | Nit: move? | |
| 89 | Nit: move? | |
| libcxx/test/std/algorithms/alg.sorting/alg.set.operations/set.union/ranges_set_union.pass.cpp | ||
| 47 | Nit: include <utility>. | |
Nit: move?