Page MenuHomePhabricator

[libc++][ranges] implement `std::ranges::set_union`
ClosedPublic

Authored by huixie90 on Jul 13 2022, 9:21 AM.

Details

Summary

[libc++][ranges] implement std::ranges::set_union

Diff Detail

Event Timeline

huixie90 created this revision.Jul 13 2022, 9:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2022, 9:21 AM
huixie90 updated this revision to Diff 444305.Jul 13 2022, 9:23 AM

add link to review

huixie90 published this revision for review.Jul 13 2022, 9:24 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
var-const accepted this revision.Jul 13 2022, 1:06 PM

LGTM with very minor nits. Thanks!

libcxx/include/__algorithm/set_union.h
63–71

If you're already refactoring this line, might as well use _LIBCPP_HIDE_FROM_ABI instead of _LIBCPP_INLINE_VISIBILITY.

71

Nit: move?

82

Nit: move?

libcxx/test/std/algorithms/alg.sorting/alg.set.operations/set.union/ranges_set_union.pass.cpp
46

Nit: include <utility>.

This revision is now accepted and ready to land.Jul 13 2022, 1:06 PM
huixie90 updated this revision to Diff 444407.Jul 13 2022, 1:36 PM
huixie90 marked 4 inline comments as done.

address review feedback

This revision was automatically updated to reflect the committed changes.