This is an archive of the discontinued LLVM Phabricator instance.

Differential D129433

[AIX][compiler-rt] Fix missing dependency of parent target
ClosedPublic

Authored by lkail on Jul 9 2022, 6:17 PM.

Details

Reviewers
hubert.reinterpretcast
tingwang
qiucf
Group Reviewers
Restricted Project
Commits
rG22b8a198cfb1: [AIX][compiler-rt] Fix missing dependency of parent target
Summary

add_dependencies(${LIB_PARENT_TARGET} aix-${libname}) should only happen when aix-${libname} is added.

Diff Detail

Event Timeline

lkail created this revision.Jul 9 2022, 6:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2022, 6:17 PM
Herald added subscribers: Enna1, mgorny, dberris. · View Herald Transcript
lkail requested review of this revision.Jul 9 2022, 6:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2022, 6:17 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B174534: Diff 443467.Jul 9 2022, 6:37 PM
hubert.reinterpretcast accepted this revision.Jul 10 2022, 4:26 PM

LGTM; thanks!

This revision is now accepted and ready to land.Jul 10 2022, 4:26 PM
Closed by commit rG22b8a198cfb1: [AIX][compiler-rt] Fix missing dependency of parent target (authored by lkail). · Explain WhyJul 10 2022, 7:49 PM
This revision was automatically updated to reflect the committed changes.
lkail added a commit: rG22b8a198cfb1: [AIX][compiler-rt] Fix missing dependency of parent target.

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
2 lines

Diff 443542

compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines if(objects_to_archive)
add_custom_command(OUTPUT "${output_dir}/${libname}.a" add_custom_command(OUTPUT "${output_dir}/${libname}.a"
COMMAND ${CMAKE_AR} -X32_64 r "${output_dir}/${libname}.a" COMMAND ${CMAKE_AR} -X32_64 r "${output_dir}/${libname}.a"
${objects_to_archive} ${objects_to_archive}
DEPENDS ${objects_to_archive}) DEPENDS ${objects_to_archive})
install(FILES "${output_dir}/${libname}.a" install(FILES "${output_dir}/${libname}.a"
DESTINATION ${install_dir}) DESTINATION ${install_dir})
add_custom_target(aix-${libname} add_custom_target(aix-${libname}
DEPENDS "${output_dir}/${libname}.a") DEPENDS "${output_dir}/${libname}.a")
endif()
add_dependencies(${LIB_PARENT_TARGET} aix-${libname}) add_dependencies(${LIB_PARENT_TARGET} aix-${libname})
endif()
endmacro() endmacro()