This is an archive of the discontinued LLVM Phabricator instance.

Differential D129350

[Orc] Honor hasJIT in JITTargetMachineBuilder::createTargetMachine
ClosedPublic

Authored by ro on Jul 8 2022, 12:37 AM.

Details

Reviewers
lhames
Commits
rG8922adf646ee: [Orc] Honor hasJIT in JITTargetMachineBuilder::createTargetMachine
Summary

Even with D129349, various SPARC JIT tests still FAIL. They are guarded by host-supports-jit. This is set from clang-repl --host-supports-jit which still returns true. It turns out the JITTargetMachineBuilder doesn't consider hasJIT at all.

This patch corrects this, turning the affected tests UNSUPPORTED.

Tested on sparcv9-sun-solaris2.11.

Diff Detail

Unit TestsFailed

TimeTest
60,140 msx64 debian > LLVM.CodeGen/NVPTX::wmma.py
60,150 msx64 debian > Polly.ScheduleOptimizer::pattern-matching-based-opts_5.ll
60,070 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp

Event Timeline

ro created this revision.Jul 8 2022, 12:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 12:37 AM
Herald added subscribers: StephenFan, fedor.sergeev, hiraditya, jyknight. · View Herald Transcript
ro requested review of this revision.Jul 8 2022, 12:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 12:37 AM
ro mentioned this in D118450: [RuntimeDyld] Handle SPARC.Jul 8 2022, 12:40 AM
Harbormaster completed remote builds in B174321: Diff 443156.Jul 8 2022, 1:48 AM
lhames accepted this revision.Jul 14 2022, 5:11 PM

LGTM. Thanks @ro!

This revision is now accepted and ready to land.Jul 14 2022, 5:11 PM
This revision was landed with ongoing or failed builds.Jul 14 2022, 11:21 PM
Closed by commit rG8922adf646ee: [Orc] Honor hasJIT in JITTargetMachineBuilder::createTargetMachine (authored by ro). · Explain Why
This revision was automatically updated to reflect the committed changes.
ro added a commit: rG8922adf646ee: [Orc] Honor hasJIT in JITTargetMachineBuilder::createTargetMachine.

Revision Contents

PathSize
llvm/
lib/
ExecutionEngine/
Orc/
4 lines

Diff 443156

llvm/lib/ExecutionEngine/Orc/JITTargetMachineBuilder.cpp

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
Expected<std::unique_ptr<TargetMachine>> Expected<std::unique_ptr<TargetMachine>>
JITTargetMachineBuilder::createTargetMachine() { JITTargetMachineBuilder::createTargetMachine() {
std::string ErrMsg; std::string ErrMsg;
auto *TheTarget = TargetRegistry::lookupTarget(TT.getTriple(), ErrMsg); auto *TheTarget = TargetRegistry::lookupTarget(TT.getTriple(), ErrMsg);
if (!TheTarget) if (!TheTarget)
return make_error<StringError>(std::move(ErrMsg), inconvertibleErrorCode()); return make_error<StringError>(std::move(ErrMsg), inconvertibleErrorCode());
if (!TheTarget->hasJIT())
return make_error<StringError>("Target has no JIT support",
inconvertibleErrorCode());
auto *TM = auto *TM =
TheTarget->createTargetMachine(TT.getTriple(), CPU, Features.getString(), TheTarget->createTargetMachine(TT.getTriple(), CPU, Features.getString(),
Options, RM, CM, OptLevel, /*JIT*/ true); Options, RM, CM, OptLevel, /*JIT*/ true);
if (!TM) if (!TM)
return make_error<StringError>("Could not allocate target machine", return make_error<StringError>("Could not allocate target machine",
inconvertibleErrorCode()); inconvertibleErrorCode());
return std::unique_ptr<TargetMachine>(TM); return std::unique_ptr<TargetMachine>(TM);
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines