This is an archive of the discontinued LLVM Phabricator instance.

Differential D129349

[Sparc] Don't claim JIT support on SPARC for now
ClosedPublic

Authored by ro on Jul 8 2022, 12:31 AM.

Details

Reviewers
lhames
Commits
rG09c1ee1086a4: [Sparc] Don't claim JIT support on SPARC for now
Summary

Until D118450 lands, there's no JIT support on SPARC, but the backend claims otherwise, leading to various testsuite failures.

This patch corrects this.

Tested on sparcv9-sun-solaris2.11.

Diff Detail

Event Timeline

ro created this revision.Jul 8 2022, 12:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 12:31 AM
Herald added subscribers: StephenFan, jrtc27, fedor.sergeev and 3 others. · View Herald Transcript
ro requested review of this revision.Jul 8 2022, 12:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 12:31 AM
ro mentioned this in D129350: [Orc] Honor hasJIT in JITTargetMachineBuilder::createTargetMachine.Jul 8 2022, 12:37 AM
ro mentioned this in D118450: [RuntimeDyld] Handle SPARC.Jul 8 2022, 12:40 AM
Harbormaster completed remote builds in B174320: Diff 443154.Jul 8 2022, 1:38 AM
lhames accepted this revision.Jul 14 2022, 5:11 PM

LGTM. Thanks @ro!

This revision is now accepted and ready to land.Jul 14 2022, 5:11 PM
This revision was landed with ongoing or failed builds.Jul 14 2022, 11:19 PM
Closed by commit rG09c1ee1086a4: [Sparc] Don't claim JIT support on SPARC for now (authored by ro). · Explain Why
This revision was automatically updated to reflect the committed changes.
ro added a commit: rG09c1ee1086a4: [Sparc] Don't claim JIT support on SPARC for now.
ro mentioned this in rG8922adf646ee: [Orc] Honor hasJIT in JITTargetMachineBuilder::createTargetMachine.Jul 14 2022, 11:21 PM

Revision Contents

PathSize
llvm/
lib/
Target/
Sparc/
2 lines
TargetInfo/
8 lines

Diff 444884

llvm/lib/Target/Sparc/CMakeLists.txt

add_llvm_component_group(Sparc HAS_JIT) add_llvm_component_group(Sparc)
set(LLVM_TARGET_DEFINITIONS Sparc.td) set(LLVM_TARGET_DEFINITIONS Sparc.td)
tablegen(LLVM SparcGenAsmMatcher.inc -gen-asm-matcher) tablegen(LLVM SparcGenAsmMatcher.inc -gen-asm-matcher)
tablegen(LLVM SparcGenAsmWriter.inc -gen-asm-writer) tablegen(LLVM SparcGenAsmWriter.inc -gen-asm-writer)
tablegen(LLVM SparcGenCallingConv.inc -gen-callingconv) tablegen(LLVM SparcGenCallingConv.inc -gen-callingconv)
tablegen(LLVM SparcGenDAGISel.inc -gen-dag-isel) tablegen(LLVM SparcGenDAGISel.inc -gen-dag-isel)
tablegen(LLVM SparcGenDisassemblerTables.inc -gen-disassembler) tablegen(LLVM SparcGenDisassemblerTables.inc -gen-disassembler)
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines

llvm/lib/Target/Sparc/TargetInfo/SparcTargetInfo.cpp

Show All 18 LinesTarget &llvm::getTheSparcV9Target() {
return TheSparcV9Target; return TheSparcV9Target;
} }
Target &llvm::getTheSparcelTarget() { Target &llvm::getTheSparcelTarget() {
static Target TheSparcelTarget; static Target TheSparcelTarget;
return TheSparcelTarget; return TheSparcelTarget;
} }
extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeSparcTargetInfo() { extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeSparcTargetInfo() {
RegisterTarget<Triple::sparc, /*HasJIT=*/true> X(getTheSparcTarget(), "sparc", RegisterTarget<Triple::sparc, /*HasJIT=*/false> X(getTheSparcTarget(),
"Sparc", "Sparc"); "sparc", "Sparc", "Sparc");
RegisterTarget<Triple::sparcv9, /*HasJIT=*/true> Y( RegisterTarget<Triple::sparcv9, /*HasJIT=*/false> Y(
getTheSparcV9Target(), "sparcv9", "Sparc V9", "Sparc"); getTheSparcV9Target(), "sparcv9", "Sparc V9", "Sparc");
RegisterTarget<Triple::sparcel, /*HasJIT=*/true> Z( RegisterTarget<Triple::sparcel, /*HasJIT=*/false> Z(
getTheSparcelTarget(), "sparcel", "Sparc LE", "Sparc"); getTheSparcelTarget(), "sparcel", "Sparc LE", "Sparc");
} }