This is an archive of the discontinued LLVM Phabricator instance.

[mlgo] Don't provide default model URLs
ClosedPublic

Authored by mtrofin on Jul 7 2022, 7:53 PM.

Details

Summary

Pointed out in Issue #56432: the current reference models may not be
quite friendly to open source projects. Their purpose is only
illustrative - the expectation is that projects would train their own.
To avoid unintentionally pulling such a model, made the URL cmake
setting require explicit user setting.

Diff Detail

Event Timeline

mtrofin created this revision.Jul 7 2022, 7:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 7:53 PM
mtrofin requested review of this revision.Jul 7 2022, 7:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 7:53 PM
yundiqian accepted this revision.Jul 7 2022, 10:22 PM
yundiqian added inline comments.
llvm/cmake/modules/TensorFlowCompile.cmake
97–98

also provide the information about where to find the downloading urls in the error message?

This revision is now accepted and ready to land.Jul 7 2022, 10:22 PM
mtrofin updated this revision to Diff 443633.Jul 11 2022, 7:37 AM

also pointing out there are model releases at the given repo

This revision was landed with ongoing or failed builds.Jul 11 2022, 7:38 AM
This revision was automatically updated to reflect the committed changes.