Page MenuHomePhabricator

yundiqian (Yundi Qian)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 26 2020, 11:13 PM (113 w, 1 d)

Recent Activity

Fri, Sep 23

yundiqian added a reviewer for D134566: Make MLIR model URLs cache variables: mtrofin.
Fri, Sep 23, 3:08 PM · Restricted Project, Restricted Project

Aug 25 2022

yundiqian accepted rGb2b460b0a040: [mlgo] Fix tests.
Aug 25 2022, 12:07 AM · Restricted Project, Restricted Project

Aug 10 2022

yundiqian accepted D131584: [mlgo][nfc] regalloc test model generator: prep for TFLite.
Aug 10 2022, 1:54 PM · Restricted Project, Restricted Project

Aug 8 2022

yundiqian retitled D131462: fix mlgo regalloc test model generation for tflite from # Enter a commit message. dfdds to fix mlgo regalloc test model generation for tflite.
Aug 8 2022, 8:40 PM · Restricted Project, Restricted Project
yundiqian requested review of D131462: fix mlgo regalloc test model generation for tflite.
Aug 8 2022, 8:37 PM · Restricted Project, Restricted Project

Aug 3 2022

yundiqian accepted D131116: [nfc][mlgo] Separate logger and training-mode model evaluator.
Aug 3 2022, 3:17 PM · Restricted Project, Restricted Project

Jul 7 2022

yundiqian accepted D129342: [mlgo] Don't provide default model URLs.
Jul 7 2022, 10:22 PM · Restricted Project, Restricted Project
yundiqian accepted D129254: [mlgo] Simplify autogenerated regalloc model.

mtrofin@ to take a look to confirm as well.

Jul 7 2022, 10:16 AM · Restricted Project, Restricted Project

May 9 2022

yundiqian accepted D124565: [mlgo] Support exposing more features than those supported by models.

what restricts that "the new features must be appended at the end of the list of features requested from the model"?

It's a requirement for development mode only (updated to clarify). To your question, see TFUtils.cpp, lines 303 and then the added lines 309 and below.

Wondering whether it is possible to relax this constraint cause it may cause trouble if there are multiple developers for the same pass

How?

As per offline discussion, will keep this constraint for now, and remove this constraint after migrating to tflite.

May 9 2022, 1:21 PM · Restricted Project, Restricted Project

Apr 28 2022

yundiqian added a comment to D124565: [mlgo] Support exposing more features than those supported by models.

what restricts that "the new features must be appended at the end of the list of features requested from the model"?

Apr 28 2022, 10:43 PM · Restricted Project, Restricted Project

Apr 25 2022

yundiqian accepted D124417: [mlgo] Factor out TensorSpec.
Apr 25 2022, 2:27 PM · Restricted Project, Restricted Project

Feb 3 2022

yundiqian accepted D118674: [nfc][mlgo][regalloc] Cache live interval feature components.
Feb 3 2022, 4:17 PM · Restricted Project

Feb 1 2022

yundiqian accepted D118707: [nfc][regalloc] Make the max inference cutoff configurable.
Feb 1 2022, 10:44 AM · Restricted Project

Jan 31 2022

yundiqian accepted D118659: [mlgo][regalloc] Factor live interval feature calculation.
Jan 31 2022, 3:06 PM · Restricted Project

Jan 18 2022

yundiqian accepted D117147: [MLGO] ML Regalloc Eviction Advisor.
Jan 18 2022, 1:11 PM · Restricted Project

Jan 11 2022

yundiqian accepted D116985: [MLGO] Add support for multiple training traces per module.
Jan 11 2022, 1:40 PM · Restricted Project

Jan 4 2022

yundiqian accepted D116076: [NFC][mlgo] Add feature declarations for the ML regalloc advisor.
Jan 4 2022, 9:22 AM · Restricted Project

Jan 3 2022

yundiqian accepted D116075: [NFC][regalloc] Pull out some AllocationOrder/CostPerUseLimit eviction logic.
Jan 3 2022, 12:18 AM · Restricted Project
yundiqian added inline comments to D116076: [NFC][mlgo] Add feature declarations for the ML regalloc advisor.
Jan 3 2022, 12:06 AM · Restricted Project

Dec 20 2021

yundiqian accepted D116074: [NFC] Expose isRematerializable and copyHint from CalcSpillWeights.
Dec 20 2021, 9:36 PM · Restricted Project

Dec 14 2021

yundiqian accepted D115764: [NFC] Expose the ReleaseModeModelRunner.
Dec 14 2021, 10:10 PM · Restricted Project
yundiqian added inline comments to D115764: [NFC] Expose the ReleaseModeModelRunner.
Dec 14 2021, 9:10 PM · Restricted Project

Dec 10 2021

yundiqian accepted D115465: [NFC][MLGO] Factor ModelUnderTrainingRunner for reuse.
Dec 10 2021, 10:49 AM · Restricted Project

Dec 8 2021

yundiqian accepted D115306: [NFC][mlgo] Generalize model runner interface.
Dec 8 2021, 4:07 PM · Restricted Project

Dec 6 2021

yundiqian added inline comments to D115195: [mlgo][regalloc] Add score calculation for training.
Dec 6 2021, 4:02 PM · Restricted Project, Restricted Project
yundiqian accepted D115195: [mlgo][regalloc] Add score calculation for training.
Dec 6 2021, 3:56 PM · Restricted Project, Restricted Project

Aug 23 2021

yundiqian accepted D108587: [MLGO] Make sure inliner logs when deleting callees.
Aug 23 2021, 2:52 PM · Restricted Project

Aug 6 2021

yundiqian accepted D107594: [NFC][MLGO] Make logging more robust.
Aug 6 2021, 3:45 AM · Restricted Project

Nov 18 2020

yundiqian accepted D91759: [NFC][TFUtils] also include output specs lookup logic in loadOutputSpecs.
Nov 18 2020, 9:20 PM · Restricted Project
yundiqian accepted D91751: [NFC][TFUtils] Extract out the output spec loader.
Nov 18 2020, 6:15 PM · Restricted Project
yundiqian added inline comments to D91751: [NFC][TFUtils] Extract out the output spec loader.
Nov 18 2020, 6:05 PM · Restricted Project
yundiqian added inline comments to D91751: [NFC][TFUtils] Extract out the output spec loader.
Nov 18 2020, 5:35 PM · Restricted Project

Oct 18 2020

yundiqian accepted D89626: [ML] Add final reward logging facility..
Oct 18 2020, 10:41 PM · Restricted Project
yundiqian requested changes to D89626: [ML] Add final reward logging facility..
Oct 18 2020, 10:10 PM · Restricted Project

Oct 5 2020

yundiqian accepted D88770: [MLInliner] Factor out logging.
Oct 5 2020, 5:36 PM · Restricted Project
yundiqian added inline comments to D88770: [MLInliner] Factor out logging.
Oct 5 2020, 10:56 AM · Restricted Project

Aug 25 2020

yundiqian accepted D86549: [MLInliner] Simplify TFUTILS_SUPPORTED_TYPES.

Yes, Mircea and I discussed about it. Doing conversion in either place is fine. The argument of doing the it here is better isolation of TF and LLVM and easier testing in LLVM

Aug 25 2020, 11:21 AM · Restricted Project

Aug 24 2020

yundiqian accepted D86481: [MLInliner] Support training that doesn't require partial rewards.
Aug 24 2020, 4:21 PM · Restricted Project
yundiqian abandoned D86407: [MLInliner] bugfix for tensor type name: float -> float32.

mtrofin is going to fix in a different way.

Aug 24 2020, 2:10 PM · Restricted Project

Aug 22 2020

yundiqian requested review of D86407: [MLInliner] bugfix for tensor type name: float -> float32.
Aug 22 2020, 2:29 PM · Restricted Project

Aug 19 2020

yundiqian accepted D86224: [NFC] Expose the -Oz module optimization pipeline to opt.
Aug 19 2020, 9:40 AM · Restricted Project

Aug 17 2020

yundiqian accepted D85674: [MLInliner] In development mode, obtain the output specs from a file.
Aug 17 2020, 1:47 PM · Restricted Project

Aug 16 2020

yundiqian added inline comments to D85674: [MLInliner] In development mode, obtain the output specs from a file.
Aug 16 2020, 11:13 PM · Restricted Project
yundiqian added inline comments to D85674: [MLInliner] In development mode, obtain the output specs from a file.
Aug 16 2020, 8:46 PM · Restricted Project

Aug 8 2020

yundiqian accepted D85577: [NFC][MLInliner] Set up the logger outside the development mode advisor.
Aug 8 2020, 8:16 PM · Restricted Project

Aug 7 2020

yundiqian accepted D85451: [NFC][MLInliner] Refactor logging implementation.
Aug 7 2020, 1:53 PM · Restricted Project
yundiqian added inline comments to D85451: [NFC][MLInliner] Refactor logging implementation.
Aug 7 2020, 1:30 AM · Restricted Project

Aug 5 2020

yundiqian accepted D85373: [llvm][MLInliner] Don't log 'mandatory' events.
Aug 5 2020, 11:23 PM · Restricted Project
yundiqian accepted D85262: [TFUtils] Expose untyped accessor to evaluation result tensors.
Aug 5 2020, 12:32 AM · Restricted Project

Aug 2 2020

yundiqian accepted D84976: [llvm] Add a parser from JSON to TensorSpec.
Aug 2 2020, 9:23 PM · Restricted Project