Details
- Reviewers
ldionne Mordante var-const - Group Reviewers
Restricted Project - Commits
- rGa13822b35d11: [libc++] Simplify type_traits a bit more
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
BTW, it's awesome to see these simplifications become possible. This is a payoff for dropping support for unreasonably old compilers.
libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/types.h | ||
---|---|---|
26 ↗ | (On Diff #452515) | why is this change required? |
libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/types.h | ||
---|---|---|
26 ↗ | (On Diff #452515) | This isn't actually required. I thought it was implementation divergence, but it's a GCC bug. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106611. @CaseyCarter @STL_MSFT you might also want to look into that. |
libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/types.h | ||
---|---|---|
26 ↗ | (On Diff #452515) | I'm missing context here - apologies for not being up to speed. MSVC's STL supports MSVC and Clang as first-class citizens (and we use libcxx's test suite with our STL), but we don't attempt to support GCC. Are you requesting any changes to MSVC's compiler or libraries here that we could help with? |
libcxx/test/libcxx/ranges/range.adaptors/range.copy.wrap/types.h | ||
---|---|---|
26 ↗ | (On Diff #452515) | The MSVC compiler has very similar bugs regarding noexcept specifications on defaulted special member functions. https://godbolt.org/z/1z4fb11hr is the full reproducer. |