[lldb] [llgs] Fix `?` packet response for running threads
ClosedPublic
Actions

Authored by mgorny on Jun 29 2022, 11:01 PM.

Details

Reviewers

labath
krytarowski
emaste
jingham

Commits

rGab9f1e88fd8a: [lldb] [llgs] Fix `?` packet response for running threads

Summary

Fix the response to ? packet for threads that are running at the time
(in non-stop mode). The previous code would wrongly send or queue
an empty response for them.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mgorny created this revision.Jun 29 2022, 11:01 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2022, 11:01 PM

Herald added a subscriber: arichardson. · View Herald Transcript

mgorny requested review of this revision.Jun 29 2022, 11:01 PM

Harbormaster completed remote builds in B172943: Diff 441269.Jun 29 2022, 11:04 PM

labath accepted this revision.Jun 30 2022, 1:34 AM

This revision is now accepted and ready to land.Jun 30 2022, 1:34 AM

mgorny added a child revision: D128893: [lldb] [llgs] Fix disabling non-stop mode.Jun 30 2022, 1:50 AM

Closed by commit rGab9f1e88fd8a: [lldb] [llgs] Fix `?` packet response for running threads (authored by mgorny). · Explain WhyJul 15 2022, 9:42 AM

This revision was automatically updated to reflect the committed changes.

mgorny added a commit: rGab9f1e88fd8a: [lldb] [llgs] Fix `?` packet response for running threads.

Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2022, 9:42 AM

Revision Contents
Changeset List

Path

Size

lldb/

source/

Plugins/

Process/

gdb-remote/

GDBRemoteCommunicationServerLLGS.cpp

16 lines

test/

API/

tools/

lldb-server/

TestNonStop.py

20 lines

Diff 445026

View Options

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp