[clang-format] Handle Verilog attributes

[HazardyKnusperkeks]

Seems straight forward.

[owenpan]

clang/lib/Format/UnwrappedLineParser.cpp

1481–1486

as peekNextToken() never returns null.

[sstwcw]

• don't check peeked token for null

[owenpan]

Can you mark D128709#3617654 as done?

clang/lib/Format/UnwrappedLineParser.cpp

1481–1486

as peekNextToken() never returns null.

clang/lib/Format/TokenAnnotator.cpp

if ((Right.is(Keywords.kw_apostrophe) ||
          (Right.is(BK_BracedInit) && Right.is(tok::l_brace))) &&
         !(Left.isOneOf(Keywords.kw_assign, Keywords.kw_unique) ||
           Keywords.isVerilogWordOperator(Left)) &&
         (Left.isOneOf(tok::r_square, tok::r_paren, tok::r_brace,
                       tok::numeric_constant) ||
          Keywords.isWordLike(Left))) {
       return false;
     }
+    // Add space in attribute like `(* ASYNC_REG = "TRUE" *)`.
+    if (Left.endsSequence(tok::star, tok::l_paren) && Right.is(tok::identifier))
+      return true;
   }
   if (Left.is(TT_ImplicitStringLiteral))
     return Right.hasWhitespaceBefore();
   if (Line.Type == LT_ObjCMethodDecl) {
     if (Left.is(TT_ObjCMethodSpecifier))
       return true;
     if (Left.is(tok::r_paren) && canBeObjCSelectorComponent(Right)) {
       // Don't space between ')' and <id> or ')' and 'new'. 'new' is not a

clang/lib/Format/UnwrappedLineParser.cpp

void UnwrappedLineParser::parseStructuralElement(
   if (Style.Language == FormatStyle::LK_TableGen &&
       FormatTok->is(tok::pp_include)) {
     nextToken();
     if (FormatTok->is(tok::string_literal))
       nextToken();
     addUnwrappedLine();
     return;
   }
+
+  if (Style.isVerilog()) {
+    // Skip things that can exist before keywords like 'if' and 'case'.
+    while (true) {
+      if (FormatTok->isOneOf(Keywords.kw_priority, Keywords.kw_unique,
+                             Keywords.kw_unique0)) {
+        nextToken();
+      } else if (FormatTok->is(tok::l_paren) &&
+                 Tokens->peekNextToken()->is(tok::star)) {
+        parseParens();
+      } else {
+        break;
+      }
+    }
+  }
+
+  // Tokens that only make sense at the beginning of a line.
   switch (FormatTok->Tok.getKind()) {
   case tok::kw_asm:
     nextToken();
     if (FormatTok->is(tok::l_brace)) {
       FormatTok->setFinalizedType(TT_InlineASMBrace);
       nextToken();
       while (FormatTok && FormatTok->isNot(tok::eof)) {
         if (FormatTok->is(tok::r_brace)) {

clang/unittests/Format/FormatTestVerilog.cpp

verifyFormat("function automatic logic [1 : 0] x\n"
                "  generate\n"
                "  endgenerate\n"
                "endfunction : x");
 }
 
 TEST_F(FormatTestVerilog, If) {
   verifyFormat("if (x)\n"
                "  x = x;");
+  verifyFormat("unique if (x)\n"
+               "  x = x;");
+  verifyFormat("unique0 if (x)\n"
+               "  x = x;");
+  verifyFormat("priority if (x)\n"
+               "  x = x;");
   verifyFormat("if (x)\n"
                "  x = x;\n"
                "x = x;");
 
   // Test else
   verifyFormat("if (x)\n"
                "  x = x;\n"
                "else if (x)\n"
TEST_F(FormatTestVerilog, If) {
   verifyFormat("if (x)\n"
                "  {x} = x;");
   verifyFormat("if (x)\n"
                "  x = {x};");
   verifyFormat("if (x)\n"
                "  x = {x};\n"
                "else\n"
                "  {x} = {x};");
+
+  // With attributes.
+  verifyFormat("(* x *) if (x)\n"
+               "  x = x;");
+  verifyFormat("(* x = \"x\" *) if (x)\n"
+               "  x = x;");
+  verifyFormat("(* x, x = \"x\" *) if (x)\n"
+               "  x = x;");
 }
 
 TEST_F(FormatTestVerilog, Operators) {
   // Test that unary operators are not followed by space.
   verifyFormat("x = +x;");
   verifyFormat("x = -x;");
   verifyFormat("x = !x;");
   verifyFormat("x = ~x;");