Page MenuHomePhabricator

[clang-format] Handle Verilog attributes
ClosedPublic

Authored by sstwcw on Jun 28 2022, 1:28 AM.

Diff Detail

Event Timeline

sstwcw created this revision.Jun 28 2022, 1:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 1:28 AM
sstwcw requested review of this revision.Jun 28 2022, 1:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 1:28 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sstwcw added a project: Restricted Project.Jun 28 2022, 1:34 AM

Seems straight forward.

This revision is now accepted and ready to land.Jun 28 2022, 1:54 AM
owenpan added inline comments.Jun 28 2022, 10:32 PM
clang/lib/Format/UnwrappedLineParser.cpp
1481–1486

as peekNextToken() never returns null.

sstwcw updated this revision to Diff 443611.Jul 11 2022, 5:39 AM
  • don't check peeked token for null
owenpan accepted this revision.Jul 11 2022, 12:54 PM

Can you mark D128709#3617654 as done?

clang/lib/Format/UnwrappedLineParser.cpp
1481–1486

as peekNextToken() never returns null.

sstwcw marked 2 inline comments as done.Jul 11 2022, 5:09 PM
This revision was automatically updated to reflect the committed changes.