[BOLT] Respect shouldPrint in dump-dot-all

[Amir]

Summary

Don't dump dot CFG graph for functions that should not be printed.

[rafauler]

Thanks

[Amir]

Also don't print loop info

[maksfb]

bolt/lib/Core/BinaryFunction.cpp

3118

[Amir]

dbgs -> outs

[Amir]

Use lower-case message

[maksfb]

LGTM, but drop "[NFC]".

bolt/lib/Core/BinaryFunction.cpp

if (DisplayGraph(Filename))
     errs() << "BOLT-ERROR: Can't display " << Filename << " with graphviz.\n";
   if (std::error_code EC = sys::fs::remove(Filename)) {
     errs() << "BOLT-WARNING: " << EC.message() << ", failed to remove "
            << Filename << "\n";
   }
 }
 
 void BinaryFunction::dumpGraphForPass(std::string Annotation) const {
+  if (!opts::shouldPrint(*this))
+    return;
+
   std::string Filename = constructFilename(getPrintName(), Annotation, ".dot");
-  outs() << "BOLT-DEBUG: Dumping CFG to " << Filename << "\n";
+  if (opts::Verbosity >= 1)
+    outs() << "BOLT-INFO: dumping CFG to " << Filename << "\n";
   dumpGraphToFile(Filename);
 }
 
 void BinaryFunction::dumpGraphToFile(std::string Filename) const {
   std::error_code EC;
   raw_fd_ostream of(Filename, EC, sys::fs::OF_None);
   if (EC) {
     if (opts::Verbosity >= 1) {
for (const DebugLocationEntry &Entry : OutputLL) {
     PrevEndAddress = MergedLL.back().HighPC;
     PrevExpr = &MergedLL.back().Expr;
   }
 
   return MergedLL;
 }
 
 void BinaryFunction::printLoopInfo(raw_ostream &OS) const {
+  if (!opts::shouldPrint(*this))
+    return;
+
   OS << "Loop Info for Function \"" << *this << "\"";
   if (hasValidProfile())
     OS << " (count: " << getExecutionCount() << ")";
   OS << "\n";
 
   std::stack<BinaryLoop *> St;
   for_each(*BLI, [&](BinaryLoop *L) { St.push(L); });
   while (!St.empty()) {