Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks for making this clearer!
mlir/include/mlir/Dialect/Math/IR/MathOps.td | ||
---|---|---|
671 | I don't think we need to explicitly mention "this lowers to .." given that's irrelevant to the definition of this op in particular; we only need to define its semantics here. (And I do intend to support this op's lowering in SPIR-V for example.) The rest LGTM! |
I don't think we need to explicitly mention "this lowers to .." given that's irrelevant to the definition of this op in particular; we only need to define its semantics here. (And I do intend to support this op's lowering in SPIR-V for example.)
The rest LGTM!