This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Math] Improve docs for round op (NFC)
ClosedPublic

Authored by chelini on Jun 27 2022, 9:18 AM.

Diff Detail

Event Timeline

chelini created this revision.Jun 27 2022, 9:18 AM
chelini requested review of this revision.Jun 27 2022, 9:18 AM
antiagainst accepted this revision.Jun 28 2022, 11:02 AM

Thanks for making this clearer!

mlir/include/mlir/Dialect/Math/IR/MathOps.td
671

I don't think we need to explicitly mention "this lowers to .." given that's irrelevant to the definition of this op in particular; we only need to define its semantics here. (And I do intend to support this op's lowering in SPIR-V for example.)

The rest LGTM!

This revision is now accepted and ready to land.Jun 28 2022, 11:02 AM
chelini updated this revision to Diff 440866.Jun 28 2022, 11:34 PM

Address comment.

This revision was landed with ongoing or failed builds.Jun 28 2022, 11:35 PM
This revision was automatically updated to reflect the committed changes.
chelini marked an inline comment as done.