This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [llgs] Fix premature server exit if multiprocess+nonstop
ClosedPublic

Authored by mgorny on Jun 27 2022, 5:56 AM.

Details

Summary

Fix lldb-server in the non-stop + multiprocess mode to exit on vStopped
only if all processes have exited, rather than when the first one exits.

Sponsored by: The FreeBSD Foundation

Diff Detail

Event Timeline

mgorny created this revision.Jun 27 2022, 5:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 5:56 AM
Herald added a subscriber: arichardson. · View Herald Transcript
mgorny requested review of this revision.Jun 27 2022, 5:56 AM
labath accepted this revision.Jun 28 2022, 6:05 AM
labath added inline comments.
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
3876

I have a feeling that, in the multi-process world, any reference to this variable is going to be a bug. It'd be best if it didn't exist.

This revision is now accepted and ready to land.Jun 28 2022, 6:05 AM
This revision was landed with ongoing or failed builds.Jun 28 2022, 12:49 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 12:49 PM