[CMake][compiler-rt] Treat AIX link options as a list

[phosek]

Summary

This addresses https://github.com/llvm/llvm-project/issues/56200
which was introduced by 30dfe016d4259398689dc1be163e0ecc804b5feb.

[hubert.reinterpretcast]

https://reviews.llvm.org/D128524 was landed. There is a slight difference in how the -Wl,-G is added.

[phosek]

In D128552#3609130, @hubert.reinterpretcast wrote:

https://reviews.llvm.org/D128524 was landed. There is a slight difference in how the -Wl,-G is added.

Those should be equivalent.

[tingwang]

In D128552#3609173, @phosek wrote:

In D128552#3609130, @hubert.reinterpretcast wrote:

https://reviews.llvm.org/D128524 was landed. There is a slight difference in how the -Wl,-G is added.

Those should be equivalent.

Sorry just closed the issue forgot mention we did try to fix. Thank you for looking into this!

compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake

 include(CMakeParseArguments)
 include(CompilerRTUtils)
 
 function(get_aix_libatomic_default_link_flags link_flags export_list)
   set(linkopts
-    "-Wl,-H512 -Wl,-D0 \
-     -Wl,-T512 -Wl,-bhalt:4 -Wl,-bernotok \
-     -Wl,-bnoentry -Wl,-bexport:${export_list} \
-     -Wl,-bmodtype:SRE -Wl,-lc")
+    -Wl,-H512 -Wl,-D0
+    -Wl,-T512 -Wl,-bhalt:4 -Wl,-bernotok
+    -Wl,-bnoentry -Wl,-bexport:${export_list}
+    -Wl,-bmodtype:SRE -Wl,-lc)
   # Add `-Wl,-G`. Quoted from release notes of cmake-3.16.0
   # > On AIX, runtime linking is no longer enabled by default.
   # See https://cmake.org/cmake/help/latest/release/3.16.html
   if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.16.0")
-    set(linkopts "-Wl,-G" "${linkopts}")
+    list(PREPEND linkopts -Wl,-G)
   endif()
   set(${link_flags} ${linkopts} PARENT_SCOPE)
 endfunction()
 
 function(get_aix_libatomic_type type)
   if(${CMAKE_VERSION} VERSION_LESS "3.16.0")
     set(${type} SHARED PARENT_SCOPE)
   else()