Page MenuHomePhabricator

[mlir][NFC] Use proper c++ namespaces in .td files
ClosedPublic

Authored by lipracer on Jun 24 2022, 8:14 AM.

Details

Summary

td files:
mlir::ArrayRef => llvm::ArrayRef
mlir::Optional=>llvm::Optional
mlir::SmallVector => llvm::SmallVector

Diff Detail

Event Timeline

lipracer created this revision.Jun 24 2022, 8:14 AM
Herald added a project: Restricted Project. · View Herald Transcript
lipracer requested review of this revision.Jun 24 2022, 8:14 AM
aartbik edited reviewers, added: rriddle; removed: aartbik.Jun 24 2022, 11:41 AM
rriddle accepted this revision.Jun 27 2022, 9:27 AM

Can you improve the commit title/description? Right now it isn't super clear, e.g. maybe just: [mlir][NFC] Use proper c++ namespaces in .td files?

This revision is now accepted and ready to land.Jun 27 2022, 9:27 AM
lipracer retitled this revision from code cleanup to 0001-mlir-NFC-Use-proper-c-namespaces-in-.td-files.patch.Jun 27 2022, 7:29 PM
lipracer edited the summary of this revision. (Show Details)
lipracer retitled this revision from 0001-mlir-NFC-Use-proper-c-namespaces-in-.td-files.patch to [mlir][NFC] Use proper c++ namespaces in .td files.

done.

I don't have permission to commit.Can you help to commit this?

This revision was automatically updated to reflect the committed changes.