[test-suite] Fix unaligned uint32_t accesses in ClamAV.

[craig.topper]

Summary

The char* here isn't 4 byte aligned so the cast to int32_t* can
create an unaligned access.

Replace with a memcpy.

[aaron.ballman]

LGTM, but at the same time, I have no idea whether we're *supposed* to make changes to the source code for these projects or not (my understanding is that they're real world code and so we don't want to change the source code because then it's not reflective of real world code any longer, but I could be totally wrong).

[craig.topper]

In D128491#3607668, @aaron.ballman wrote:

LGTM, but at the same time, I have no idea whether we're *supposed* to make changes to the source code for these projects or not (my understanding is that they're real world code and so we don't want to change the source code because then it's not reflective of real world code any longer, but I could be totally wrong).

FWIW the current ClamAV repo uses a packed union to convert to int32 and has for 14 years. https://github.com/Cisco-Talos/clamav/blob/62bf3bea329a13d8416d72d289f72bba3e5a1933/libclamav/others.h

It looks like the copy in llvm-test-suite was created 15 years ago.

[MaskRay]

LGTM, since the upstream has fixed it, even in a different way. A misaligned access would manifest as a -fsanitize=alignment failure. llvm test suite can be useful to benchmark sanitizers.

MultiSource/Applications/ClamAV/others.h

 #define __OTHERS_H_LC
 
 #if HAVE_CONFIG_H
 #include "clamav-config.h"
 #endif
 
 #include <stdio.h>
 #include <stdlib.h>
+#include <string.h>
 #include "cltypes.h"
 
 #include "clamav.h"
 #include "dconf.h"
 
 extern uint8_t cli_debug_flag, cli_leavetemps_flag;
 
 /*

 unsigned int cli_rndnum(unsigned int max);
 int cli_filecopy(const char *src, const char *dest);
 bitset_t *cli_bitset_init(void);
 void cli_bitset_free(bitset_t *bs);
 int cli_bitset_set(bitset_t *bs, unsigned long bit_offset);
 int cli_bitset_test(bitset_t *bs, unsigned long bit_offset);
 
 #if WORDS_BIGENDIAN == 0
-#define cli_readint32(buff) (*(const int32_t *)(buff))
-#define cli_writeint32(offset, value) (*(uint32_t *)(offset)=(uint32_t)(value))
+static inline int32_t cli_readint32(const char *buff) {
+  int32_t ret;
+  memcpy(&ret, buff, sizeof(ret));
+  return ret;
+}
+
+static inline void cli_writeint32(char *offset, uint32_t value) {
+  memcpy(offset, &value, sizeof(value));
+}
 #else
 static inline int32_t cli_readint32(const char *buff)
 {
   int32_t ret;
     ret = buff[0] & 0xff;
     ret |= (buff[1] & 0xff) << 8;
     ret |= (buff[2] & 0xff) << 16;
     ret |= (buff[3] & 0xff) << 24;