This is an archive of the discontinued LLVM Phabricator instance.

Differential D128086

[mlir][sparse] renable f16 tests
ClosedPublic

Authored by aartbik on Jun 17 2022, 11:58 AM.

Details

Reviewers
bixia
wrengr
Peiming
yinying-lisa-li
bkramer
Commits
rG86d5d34c7223: [mlir][sparse] renable f16 tests
Summary

Sparse library ABI issues are fixed.

https://github.com/llvm/llvm-project/issues/55992

Diff Detail

Event Timeline

aartbik created this revision.Jun 17 2022, 11:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2022, 11:58 AM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 19 others. · View Herald Transcript
aartbik requested review of this revision.Jun 17 2022, 11:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2022, 11:58 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
aartbik added reviewers: bixia, wrengr, Peiming, yinying-lisa-li.Jun 17 2022, 11:58 AM
aartbik added a reviewer: bkramer.Jun 17 2022, 12:45 PM
bkramer accepted this revision.Jun 17 2022, 12:46 PM

looks good

This revision is now accepted and ready to land.Jun 17 2022, 12:46 PM
This revision was landed with ongoing or failed builds.Jun 17 2022, 12:48 PM
Closed by commit rG86d5d34c7223: [mlir][sparse] renable f16 tests (authored by aartbik). · Explain Why
This revision was automatically updated to reflect the committed changes.
aartbik added a commit: rG86d5d34c7223: [mlir][sparse] renable f16 tests.
Harbormaster completed remote builds in B170577: Diff 438000.Jun 17 2022, 1:06 PM

Revision Contents

PathSize
mlir/
test/
Integration/
Dialect/
SparseTensor/
CPU/
2 lines
2 lines

Diff 438014

mlir/test/Integration/Dialect/SparseTensor/CPU/dense_output_f16.mlir

// FIXME: The runtime needs support for _Float16 on X86, see PR55992
// UNSUPPORTED: i386, x86_64
// RUN: mlir-opt %s --sparse-compiler | \ // RUN: mlir-opt %s --sparse-compiler | \
// RUN: mlir-cpu-runner \ // RUN: mlir-cpu-runner \
// RUN: -e entry -entry-point-result=void \ // RUN: -e entry -entry-point-result=void \
// RUN: -shared-libs=%mlir_integration_test_dir/libmlir_c_runner_utils%shlibext | \ // RUN: -shared-libs=%mlir_integration_test_dir/libmlir_c_runner_utils%shlibext | \
// RUN: FileCheck %s // RUN: FileCheck %s
#SparseVector = #sparse_tensor.encoding<{dimLevelType = ["compressed"]}> #SparseVector = #sparse_tensor.encoding<{dimLevelType = ["compressed"]}>
#DenseVector = #sparse_tensor.encoding<{dimLevelType = ["dense"]}> #DenseVector = #sparse_tensor.encoding<{dimLevelType = ["dense"]}>
▲ Show 20 Lines • Show All 82 Lines • Show Last 20 Lines

mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_sum_f16.mlir

// FIXME: The runtime needs support for _Float16 on X86, see PR55992
// UNSUPPORTED: i386, x86_64
// RUN: mlir-opt %s --sparse-compiler | \ // RUN: mlir-opt %s --sparse-compiler | \
// RUN: mlir-cpu-runner \ // RUN: mlir-cpu-runner \
// RUN: -e entry -entry-point-result=void \ // RUN: -e entry -entry-point-result=void \
// RUN: -shared-libs=%mlir_integration_test_dir/libmlir_c_runner_utils%shlibext | \ // RUN: -shared-libs=%mlir_integration_test_dir/libmlir_c_runner_utils%shlibext | \
// RUN: FileCheck %s // RUN: FileCheck %s
!Filename = !llvm.ptr<i8> !Filename = !llvm.ptr<i8>
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines