This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX11] Correct disassembly of DPP variants of VOPC64 opcodes
ClosedPublic

Authored by dp on Jun 17 2022, 10:59 AM.

Details

Summary

Summary of changes:

  • Correct suffix of cmpx opcodes - bug 56091.
  • Add isVOPC64DPP - bug 56065.
  • Rename recently added disassembler tests (change asm to dasm).
  • Add more tests.

Diff Detail

Event Timeline

dp created this revision.Jun 17 2022, 10:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2022, 10:59 AM
dp requested review of this revision.Jun 17 2022, 10:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2022, 10:59 AM

Overall looks good, thanks!

llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop3_dpp8.txt
1

I see we only had wave32 before on these tests. Can you add wave64?

dp updated this revision to Diff 438008.Jun 17 2022, 12:29 PM

Added tests for wavesize=64

This revision is now accepted and ready to land.Jun 17 2022, 12:50 PM
This revision was landed with ongoing or failed builds.Jun 20 2022, 4:23 AM
This revision was automatically updated to reflect the committed changes.
llvm/test/MC/Disassembler/AMDGPU/gfx11_asm_vop3_dpp8.txt