This is an archive of the discontinued LLVM Phabricator instance.

[MachineBlockPlacementStats] Added check for "-filter-print-funcs" option to the machine-block-placement-stats
ClosedPublic

Authored by mingmingl on Jun 16 2022, 5:27 PM.

Details

Summary

The code change is similar to https://reviews.llvm.org/D114310; basically allow users to filter stats for a specific function.

Diff Detail

Event Timeline

mingmingl created this revision.Jun 16 2022, 5:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2022, 5:27 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
mingmingl requested review of this revision.Jun 16 2022, 5:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2022, 5:27 PM
davidxl accepted this revision.Jun 16 2022, 6:45 PM

lgtm

This revision is now accepted and ready to land.Jun 16 2022, 6:45 PM

No code change.

Update commit message with differential revision link.

This revision was landed with ongoing or failed builds.Jun 16 2022, 10:09 PM
This revision was automatically updated to reflect the committed changes.

If forgot to add Differential Revision, just leave it. Reverting a commit and recommitting just to add the information only adds more churn.
You can click "Add Action" -> "Close Revision" to manually close a revision.

If forgot to add Differential Revision, just leave it. Reverting a commit and recommitting just to add the information only adds more churn.
You can click "Add Action" -> "Close Revision" to manually close a revision.

Acknowledged. I have used the "close revision" button and add differential revision link in Github commit link in the past and will do it in the future.