[gdb-scripts] Add to_string methods to printer implementations

[krzysz00]

Summary

Some GDB versions require all prettyprinter classes to define to_string.
This commit adds these definitions.

llvm/utils/gdb-scripts/prettyprinters.py

class PointerIntPairPrinter:
   def __init__(self, pointer, value):
     self.pointer = pointer
     self.value = value
 
   def children(self):
     yield ('pointer', self.pointer)
     yield ('value', self.value)
 
+  def to_string(self):
+    return '(%s, %s)' % self.pointer.type, self.value.type
+
 def make_pointer_int_pair_printer(val):
   """Factory for an llvm::PointerIntPair printer."""
   try:
     pointer, value = get_pointer_int_pair(val)
   except gdb.error:
     return None  # If PointerIntPair cannot be analyzed, print as raw value.
   pointer_type = val.type.template_argument(0)
   value_type = val.type.template_argument(2)

mlir/utils/gdb-scripts/prettyprinters.py

class StoragePrinter:
 
   def children(self):
     for field in self.val.type.fields():
       if field.is_base_class:
         yield '<%s>' % field.name, self.val.cast(field.type)
       else:
         yield field.name, self.val[field.name]
 
+  def to_string(self):
+    return 'mlir::Storage'
 
 class TupleTypeStoragePrinter(StoragePrinter):
 
   def children(self):
     for child in StoragePrinter.children(self):
       yield child
     pointer_type = gdb.lookup_type('mlir::Type').pointer()
     elements = (self.val.address + 1).cast(pointer_type)
     for i in range(self.val['numElements']):
       yield 'elements[%u]' % i, elements[i]
 
+  def to_string(self):
+    return 'mlir::TupleTypeStorage of %u elements' % self.val['numElements']
 
 class FusedLocationStoragePrinter(StoragePrinter):
 
   def children(self):
     for child in StoragePrinter.children(self):
       yield child
     pointer_type = gdb.lookup_type('mlir::Location').pointer()
     elements = (self.val.address + 1).cast(pointer_type)
     for i in range(self.val['numLocs']):
       yield 'locs[%u]' % i, elements[i]
 
+  def to_string(self):
+    return 'mlir::FusedLocationStorage of %u locs' % self.val['numLocs']
+
 
 class StorageTypeMap:
   """Maps a TypeID to the corresponding concrete type.
 
   Types need to be registered by name before the first lookup.
   """
 
   def __init__(self):
def get_attr_or_type_printer(val, get_type_id):
   class AttrOrTypePrinter:
 
     def __init__(self, type_id, impl):
       self.type_id = type_id
       self.impl = impl
 
     def children(self):
       yield 'typeID', self.type_id
-      yield 'cast<%s>(impl)' % self.impl.type, self.impl
+      yield 'impl', self.impl
+
+    def to_string(self):
+      return 'cast<%s>' % self.impl.type
 
   if not val['impl']:
     return None
   impl = val['impl'].dereference()
   type_id = get_type_id(impl)
   concrete_type = storage_type_map[type_id]
   if not concrete_type:
     return None
   # 3rd template argument of StorageUserBase is the storage type.
   storage_type = concrete_type.fields()[0].type.template_argument(2)
   if not storage_type:
     return None
   return AttrOrTypePrinter(type_id, impl.cast(storage_type))
 
 
 class ImplPrinter:
   """Printer for an instance with a single 'impl' member pointer."""
 
   def __init__(self, val):
+    self.val = val
     self.impl = val['impl']
 
   def children(self):
-    yield 'impl', (self.impl.dereference() if self.impl else self.impl)
+    if self.impl:
+      yield 'impl', self.impl.dereference()
+
+  def to_string(self):
+    return self.val.type.name
 
 
 # Printers of types deriving from Attribute::AttrBase or Type::TypeBase.
 for name in [
     # mlir/IR/Attributes.h
     'ArrayAttr',
     'DictionaryAttr',
     'FloatAttr',