This is an archive of the discontinued LLVM Phabricator instance.

Differential D127940

[JITLink][AArch64][NFC] Suppress unused variable error.
ClosedPublic

Authored by sunho on Jun 15 2022, 11:14 PM.

Details

Reviewers
lhames
sgraenitz
chapuni
Commits
rGf3e7e4d786fa: [JITLink][AArch64][NFC] Suppress unused variable error.
Summary

Suppress unused variable error when assertion got disabled.

Diff Detail

Event Timeline

sunho created this revision.Jun 15 2022, 11:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 11:14 PM
Herald added subscribers: StephenFan, kristof.beyls. · View Herald Transcript
sunho requested review of this revision.Jun 15 2022, 11:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 11:14 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
chapuni accepted this revision.Jun 15 2022, 11:23 PM

I think this is a trivial fix and you may commit w/o review.

This revision is now accepted and ready to land.Jun 15 2022, 11:23 PM
This revision was landed with ongoing or failed builds.Jun 15 2022, 11:30 PM
Closed by commit rGf3e7e4d786fa: [JITLink][AArch64][NFC] Suppress unused variable error. (authored by sunho). · Explain Why
This revision was automatically updated to reflect the committed changes.
sunho added a commit: rGf3e7e4d786fa: [JITLink][AArch64][NFC] Suppress unused variable error..
Harbormaster completed remote builds in B170196: Diff 437453.Jun 16 2022, 12:56 AM

Revision Contents

PathSize
llvm/
include/
llvm/
ExecutionEngine/
JITLink/
1 line

Diff 437454

llvm/include/llvm/ExecutionEngine/JITLink/aarch64.h

Show First 20 Lines • Show All 260 Lines • ▼ Show 20 Lines bool visitEdge(LinkGraph &G, Block *B, Edge &E) {
case aarch64::TLVPage21: { case aarch64::TLVPage21: {
KindToSet = aarch64::Page21; KindToSet = aarch64::Page21;
break; break;
} }
case aarch64::GOTPageOffset12: case aarch64::GOTPageOffset12:
case aarch64::TLVPageOffset12: { case aarch64::TLVPageOffset12: {
KindToSet = aarch64::PageOffset12; KindToSet = aarch64::PageOffset12;
uint32_t RawInstr = *(const support::ulittle32_t *)FixupPtr; uint32_t RawInstr = *(const support::ulittle32_t *)FixupPtr;
(void)RawInstr;
assert(E.getAddend() == 0 && assert(E.getAddend() == 0 &&
"GOTPageOffset12/TLVPageOffset12 with non-zero addend"); "GOTPageOffset12/TLVPageOffset12 with non-zero addend");
assert((RawInstr & 0xfffffc00) == 0xf9400000 && assert((RawInstr & 0xfffffc00) == 0xf9400000 &&
"RawInstr isn't a 64-bit LDR immediate"); "RawInstr isn't a 64-bit LDR immediate");
break; break;
} }
case aarch64::PointerToGOT: { case aarch64::PointerToGOT: {
KindToSet = aarch64::Delta64; KindToSet = aarch64::Delta64;
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines