Pre gfx1030 null for sdst is different.
c97436f8b6e2 [AMDGPU] Use null for dead sdst operand - requires a change to make
it not apply to pre gfx1030
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp | ||
---|---|---|
695 | This should be allowed on gfx11 as well, I suppose. I.e. we may need a new subtarget function if null can be used as an sdst and alike. | |
llvm/test/CodeGen/AMDGPU/carryout-selection.ll | ||
56–59 | Add separate run lines for gfx1030 with wave32 and wave64? | |
llvm/test/CodeGen/AMDGPU/mad_u64_u32.ll | ||
3 | Change gfx1010 lines to gfx1030 maybe? | |
23 | This is strange, I do not see FeatureGFX10_3Insts listed for gfx11. |
llvm/lib/Target/AMDGPU/SIShrinkInstructions.cpp | ||
---|---|---|
695 | gfx11 also has FeatureGFX10_3Insts so is covered with this change. However, do you think a new subtarget function would be better? I was undecided. The current change works for now - if I submit this one and we decide to implement a new subtarget function that can go in as a separate commit? | |
llvm/test/CodeGen/AMDGPU/mad_u64_u32.ll | ||
23 | Yes, it is there. |
LGTM apart from the missing checks in mad_u64_u32.ll
llvm/test/CodeGen/AMDGPU/mad_u64_u32.ll | ||
---|---|---|
14 | These checks should not have disappeared |
This should be allowed on gfx11 as well, I suppose. I.e. we may need a new subtarget function if null can be used as an sdst and alike.