[analyzer][NFC] Remove unused ExprEngine::evalBinOp functions

[martong]

LGTM

Do we have a tool to automatically discover unused member functions? (There might be so many of them in CSA...)

[steakhal]

In D127732#3581883, @martong wrote:

LGTM

Do we have a tool to automatically discover unused member functions? (There might be so many of them in CSA...)

I don't :(

The closest I found on the web is this: https://github.com/ttsiodras/DeadFunctionsDetector
But I haven't experimented with it yet.

clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h

ProgramStateRef handleLVectorSplat(ProgramStateRef state,
                                      StmtNodeBuilder &Bldr,
                                      ExplodedNode *Pred);
 
   void handleUOExtension(ExplodedNodeSet::iterator I,
                          const UnaryOperator* U,
                          StmtNodeBuilder &Bldr);
 
 public:
-  SVal evalBinOp(ProgramStateRef state, BinaryOperator::Opcode op,
-                 NonLoc L, NonLoc R, QualType T) {
-    return svalBuilder.evalBinOpNN(state, op, L, R, T);
-  }
-
-  SVal evalBinOp(ProgramStateRef state, BinaryOperator::Opcode op,
-                 NonLoc L, SVal R, QualType T) {
-    return R.isValid() ? svalBuilder.evalBinOpNN(state, op, L,
-                                                 R.castAs<NonLoc>(), T) : R;
-  }
-
   SVal evalBinOp(ProgramStateRef ST, BinaryOperator::Opcode Op,
                  SVal LHS, SVal RHS, QualType T) {
     return svalBuilder.evalBinOp(ST, Op, LHS, RHS, T);
   }
 
   /// By looking at a certain item that may be potentially part of an object's
   /// ConstructionContext, retrieve such object's location. A particular
   /// statement can be transparently passed as \p Item in most cases.