Page MenuHomePhabricator

[mlir][LLVMIR] Ask ICmpOp to return vector<Nxi1> when needed
ClosedPublic

Authored by myhsu on Jun 10 2022, 2:14 PM.

Details

Summary

If any of the operands for ICmpOp is a vector, returns a vector<Nxi1>, rather than an i1 type result.

Diff Detail

Event Timeline

myhsu created this revision.Jun 10 2022, 2:14 PM
myhsu requested review of this revision.Jun 10 2022, 2:14 PM
Mogball added inline comments.Jun 10 2022, 6:11 PM
mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
290

Can you define this builder in the source file?

myhsu updated this revision to Diff 436951.Jun 14 2022, 2:42 PM
myhsu marked an inline comment as done.

Put custom builder for ICmpOp into .cpp file.

Mogball accepted this revision.Jun 14 2022, 2:47 PM
This revision is now accepted and ready to land.Jun 14 2022, 2:47 PM