This is an archive of the discontinued LLVM Phabricator instance.

[flang][lowering] Ignore compiler directives
ClosedPublic

Authored by awarzynski on Jun 9 2022, 9:17 AM.

Details

Summary

This patch simply replaces a TODO with a warning.

This is part of the upstreaming effort from the fir-dev branch in [1].

[1] https://github.com/flang-compiler/f18-llvm-project

Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>

Diff Detail

Event Timeline

awarzynski created this revision.Jun 9 2022, 9:17 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added a subscriber: mehdi_amini. · View Herald Transcript
awarzynski requested review of this revision.Jun 9 2022, 9:17 AM
kiranchandramohan accepted this revision.Jun 9 2022, 9:26 AM

LGTM.

flang/test/Lower/compiler-directive.f90
3

Assuming for warnings, the RUN invocation does not fail

This revision is now accepted and ready to land.Jun 9 2022, 9:26 AM
This revision was automatically updated to reflect the committed changes.
awarzynski added inline comments.Jun 10 2022, 8:27 AM
flang/test/Lower/compiler-directive.f90
3

Does not fail for warnings, fails for errors :)