llvm-reduce: Support replacing FP values with 1.0

[arsenm]

Fix test

[aeubanks]

lg if test comments are addressed

llvm/test/tools/llvm-reduce/remove-operands-fp.ll

43–45

these aren't used

49

these store aren't relevant to the test

57

was this meant to be zeroinitializer?

[arsenm]

llvm/test/tools/llvm-reduce/remove-operands-fp.ll

49

Still feels weird to be testing dead defs

57

Fixed and rounded out the set to check all of 0/1/undef/nan

[arsenm]

6b8bd0f72df8dadc7cb23ccaa4ba3bb257e367a5

llvm/test/tools/llvm-reduce/remove-operands-fp.ll

+; Test that llvm-reduce can reduce floating point operands
+;
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=operands-undef --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck %s --check-prefixes=CHECK,UNDEF < %s
+
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=operands-one --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck %s --check-prefixes=CHECK,ONE < %s
+
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=operands-zero --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck %s --check-prefixes=CHECK,ZERO < %s
+
+; RUN: llvm-reduce --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck %s --check-prefixes=CHECK,ZERO < %s
+
+; CHECK-INTERESTINGNESS: = fadd float %
+; CHECK-INTERESTINGNESS: = fadd float
+
+; CHECK-INTERESTINGNESS: = fadd <2 x float>
+; CHECK-INTERESTINGNESS: = fadd <2 x float>
+; CHECK-INTERESTINGNESS: = fadd <2 x float>
+
+; CHECK-LABEL: define void @foo(
+
+; UNDEF: %fadd0 = fadd float %arg0, undef
+; UNDEF: %fadd1 = fadd float undef, undef
+; UNDEF: %fadd2 = fadd <2 x float> undef, undef
+; UNDEF: %fadd3 = fadd <2 x float> undef, undef
+; UNDEF: %fadd4 = fadd <2 x float> undef, <float 1.000000e+00, float 1.000000e+00>
+
+; ZERO: %fadd0 = fadd float %arg0, 0.000000e+00
+; ZERO: %fadd1 = fadd float 0.000000e+00, 0.000000e+00
+; ZERO: %fadd2 = fadd <2 x float> zeroinitializer, zeroinitializer
+; ZERO: %fadd3 = fadd <2 x float> zeroinitializer, zeroinitializer
+; ZERO: %fadd4 = fadd <2 x float> zeroinitializer, zeroinitializer
+
+; ONE: %fadd0 = fadd float %arg0, 1.000000e+00
+; ONE: %fadd1 = fadd float 1.000000e+00, 1.000000e+00
+; ONE: %fadd2 = fadd <2 x float> <float 1.000000e+00, float 1.000000e+00>, <float 1.000000e+00, float 1.000000e+00>
+; ONE: %fadd3 = fadd <2 x float> <float 1.000000e+00, float 1.000000e+00>, <float 1.000000e+00, float 1.000000e+00>
+; ONE: %fadd4 = fadd <2 x float> <float 1.000000e+00, float 1.000000e+00>, <float 1.000000e+00, float 1.000000e+00>
+
+declare float @llvm.fma.f32(float, float, float)
+declare <2 x float> @llvm.fma.v2f32(<2 x float>, <2 x float>, <2 x float>)
+
+define void @foo(float %arg0, float %arg1, <2 x float> %arg2, <2 x float> %arg3) {
+bb0:
+  %fadd0 = fadd float %arg0, %arg1
+  store float %fadd0, float* undef
+
+  %fadd1 = fadd float %arg0, %arg1
+  store float %fadd1, float* undef
+
+  %fadd2 = fadd <2 x float> %arg2, %arg3
+  store <2 x float> %fadd2, <2 x float>* undef
+
+  %fadd3 = fadd <2 x float> %arg2, %arg3
+  store <2 x float> %fadd3, <2 x float>* undef
+
+  %fadd4 = fadd <2 x float> %arg2, <float 1.0, float 1.0>
+  store <2 x float> %fadd4, <2 x float>* undef
+
+  ret void
+}

llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "ReduceOperands.h"
 #include "llvm/IR/Constants.h"
 #include "llvm/IR/InstIterator.h"
 #include "llvm/IR/InstrTypes.h"
 #include "llvm/IR/Operator.h"
+#include "llvm/IR/PatternMatch.h"
 #include "llvm/IR/Type.h"
 
 using namespace llvm;
+using namespace PatternMatch;
 
 static void
 extractOperandsFromModule(Oracle &O, Module &Program,
                           function_ref<Value *(Use &)> ReduceValue) {
   for (auto &F : Program.functions()) {
     for (auto &I : instructions(&F)) {
       for (auto &Op : I.operands()) {
         Value *Reduced = ReduceValue(Op);
static bool isOne(Use &Op) {
   return C && C->isOneValue();
 }
 
 static bool isZero(Use &Op) {
   auto *C = dyn_cast<Constant>(Op);
   return C && C->isNullValue();
 }
 
+static bool isZeroOrOneFP(Value *Op) {
+  const APFloat *C;
+  return match(Op, m_APFloat(C)) &&
+         ((C->isZero() && !C->isNegative()) || C->isExactlyValue(1.0));
+}
+
 static bool shouldReduceOperand(Use &Op) {
   Type *Ty = Op->getType();
   if (Ty->isLabelTy() || Ty->isMetadataTy())
     return false;
   // TODO: be more precise about which GEP operands we can reduce (e.g. array
   // indexes)
   if (isa<GEPOperator>(Op.getUser()))
     return false;
void llvm::reduceOperandsUndefDeltaPass(TestRunner &Test) {
   runDeltaPass(Test, [ReduceValue](Oracle &O, Module &Program) {
     extractOperandsFromModule(O, Program, ReduceValue);
   });
 }
 
 void llvm::reduceOperandsOneDeltaPass(TestRunner &Test) {
   errs() << "*** Reducing Operands to one...\n";
   auto ReduceValue = [](Use &Op) -> Value * {
-    // TODO: support floats
     if (!shouldReduceOperand(Op))
       return nullptr;
-    auto *Ty = dyn_cast<IntegerType>(Op->getType());
-    if (!Ty)
-      return nullptr;
+
+    Type *Ty = Op->getType();
+    if (auto *IntTy = dyn_cast<IntegerType>(Ty)) {
       // Don't replace existing ones and zeroes.
-    return (isOne(Op) || isZero(Op)) ? nullptr : ConstantInt::get(Ty, 1);
+      return (isOne(Op) || isZero(Op)) ? nullptr : ConstantInt::get(IntTy, 1);
+    }
+
+    if (Ty->isFloatingPointTy())
+      return isZeroOrOneFP(Op) ? nullptr : ConstantFP::get(Ty, 1.0);
+
+    if (VectorType *VT = dyn_cast<VectorType>(Ty)) {
+      if (isZeroOrOneFP(Op))
+        return nullptr;
+
+      return ConstantVector::getSplat(
+          VT->getElementCount(), ConstantFP::get(VT->getElementType(), 1.0));
+    }
+
+    return nullptr;
   };
   runDeltaPass(Test, [ReduceValue](Oracle &O, Module &Program) {
     extractOperandsFromModule(O, Program, ReduceValue);
   });
 }
 
 void llvm::reduceOperandsZeroDeltaPass(TestRunner &Test) {
   errs() << "*** Reducing Operands to zero...\n";