Page MenuHomePhabricator

swamulism (Samuel Eubanks)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 8 2020, 4:16 PM (45 w, 1 d)

Recent Activity

Mon, Sep 27

swamulism accepted D110534: [llvm-reduce] Reduce metadata references..
Mon, Sep 27, 8:21 PM · Restricted Project

Sep 15 2021

swamulism added a comment to D108903: [llvm-reduce] Add reduce operands pass.

Thanks for looking through this!

Sep 15 2021, 7:57 PM · Restricted Project
swamulism updated the diff for D108903: [llvm-reduce] Add reduce operands pass.

Address comments

Sep 15 2021, 7:53 PM · Restricted Project

Sep 14 2021

swamulism updated the diff for D108903: [llvm-reduce] Add reduce operands pass.

Update incorrect docs

Sep 14 2021, 7:38 PM · Restricted Project
swamulism updated the diff for D108903: [llvm-reduce] Add reduce operands pass.

Change from reducing to null to reducing to undef

Sep 14 2021, 5:59 PM · Restricted Project

Sep 8 2021

swamulism updated the diff for D108903: [llvm-reduce] Add reduce operands pass.

Add missing newline

Sep 8 2021, 5:15 PM · Restricted Project
swamulism updated the diff for D108903: [llvm-reduce] Add reduce operands pass.

Add documentation to getNullValue and remove hasNullValue

Sep 8 2021, 3:24 PM · Restricted Project

Sep 7 2021

swamulism updated the diff for D108903: [llvm-reduce] Add reduce operands pass.

Add Constant::hasNullValue

Sep 7 2021, 4:22 PM · Restricted Project
swamulism added a comment to D108903: [llvm-reduce] Add reduce operands pass.

Also no, that can be separated - place it before Constant::getNullValue() / base it on that function,
and change Constant::getNullValue() to first assert that said new function says there is such a constant.

But, i'm still not sold on null everywhere. E.g. div-by-zero is ub, gep inbounds of null w/ non-zero offset is null, etc.

Sep 7 2021, 4:13 PM · Restricted Project
swamulism added a comment to D108903: [llvm-reduce] Add reduce operands pass.

Sure I suppose we can split up this patch
@swamulism can you do that?

Sep 7 2021, 3:42 PM · Restricted Project

Sep 5 2021

swamulism added inline comments to D108903: [llvm-reduce] Add reduce operands pass.
Sep 5 2021, 3:50 PM · Restricted Project
swamulism updated the diff for D108903: [llvm-reduce] Add reduce operands pass.

[llvm-reduce] Update reduce operand test and fix pass name

Sep 5 2021, 3:49 PM · Restricted Project

Aug 29 2021

swamulism updated the summary of D108903: [llvm-reduce] Add reduce operands pass.
Aug 29 2021, 7:42 PM · Restricted Project
swamulism requested review of D108903: [llvm-reduce] Add reduce operands pass.
Aug 29 2021, 7:40 PM · Restricted Project

Aug 23 2021

swamulism accepted D108568: [llvm-reduce] Remove various module data.
Aug 23 2021, 5:39 PM · Restricted Project

Apr 26 2021

swamulism added inline comments to D101278: [llvm-reduce] Add flag to only run specific passes.
Apr 26 2021, 4:48 PM · Restricted Project
swamulism accepted D101279: [llvm-reduce] Don't unset dso_local on implicitly dso_local GVs.
Apr 26 2021, 4:44 PM · Restricted Project

Apr 1 2021

swamulism updated the diff for D99634: [llvm-reduce] Add header guards and fix clang-tidy warnings.

Add files to cmake and ninja build config

Apr 1 2021, 7:47 PM · Restricted Project

Mar 31 2021

swamulism updated the diff for D99634: [llvm-reduce] Add header guards and fix clang-tidy warnings.

Update header comment

Mar 31 2021, 6:27 PM · Restricted Project
swamulism updated the diff for D99634: [llvm-reduce] Add header guards and fix clang-tidy warnings.

Move DeltaManager.h definition to .cpp

Mar 31 2021, 6:24 PM · Restricted Project

Mar 30 2021

swamulism added reviewers for D99634: [llvm-reduce] Add header guards and fix clang-tidy warnings: aeubanks, fhahn, arsenm, lebedev.ri.
Mar 30 2021, 8:35 PM · Restricted Project
swamulism updated the diff for D99634: [llvm-reduce] Add header guards and fix clang-tidy warnings.
Mar 30 2021, 8:33 PM · Restricted Project
swamulism requested review of D99634: [llvm-reduce] Add header guards and fix clang-tidy warnings.
Mar 30 2021, 8:05 PM · Restricted Project
swamulism added reviewers for D99632: [llvm-reduce] Move tests to tools folder: aeubanks, fhahn, arsenm, lebedev.ri.
Mar 30 2021, 7:32 PM · Restricted Project
swamulism requested review of D99632: [llvm-reduce] Move tests to tools folder.
Mar 30 2021, 6:54 PM · Restricted Project

Mar 22 2021

swamulism updated the diff for D98673: [llvm-reduce] Remove dso_local when possible.

Actually conform to clang-tidy standards

Mar 22 2021, 7:53 PM · Restricted Project
swamulism updated the diff for D98673: [llvm-reduce] Remove dso_local when possible.

Conform to clang-tidy standards

Mar 22 2021, 6:17 PM · Restricted Project
swamulism updated the diff for D98673: [llvm-reduce] Remove dso_local when possible.

Add header guard and format docs

Mar 22 2021, 4:44 PM · Restricted Project

Mar 15 2021

swamulism added reviewers for D98673: [llvm-reduce] Remove dso_local when possible: lebedev.ri, arsenm, fhahn.
Mar 15 2021, 5:33 PM · Restricted Project
swamulism requested review of D98673: [llvm-reduce] Remove dso_local when possible.
Mar 15 2021, 5:30 PM · Restricted Project

Dec 11 2020

swamulism updated the summary of D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect .
Dec 11 2020, 7:35 PM · Restricted Project, Restricted Project
swamulism retitled D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect from Make NPM OptBisectInstrumentation to use global singleton OptBisect to Make NPM OptBisectInstrumentation use global singleton OptBisect .
Dec 11 2020, 7:34 PM · Restricted Project, Restricted Project
swamulism updated the summary of D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect .
Dec 11 2020, 7:33 PM · Restricted Project, Restricted Project
swamulism retitled D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect from Set NPM OptBisect to use global singleton OptBisect to Make NPM OptBisectInstrumentation to use global singleton OptBisect .
Dec 11 2020, 7:33 PM · Restricted Project, Restricted Project
swamulism retitled D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect from Set legacy pass manager OptBisect to same as NPM OptBisect to Set NPM OptBisect to use global singleton OptBisect .
Dec 11 2020, 7:32 PM · Restricted Project, Restricted Project
swamulism updated the diff for D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect .

Update comment strings

Dec 11 2020, 7:30 PM · Restricted Project, Restricted Project
swamulism updated the diff for D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect .

Address comments

Dec 11 2020, 7:27 PM · Restricted Project, Restricted Project
swamulism added a comment to D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect .

Thank you for the comments and code review!

Dec 11 2020, 7:07 PM · Restricted Project, Restricted Project
swamulism updated the diff for D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect .

Updating to set npm OptBisect to use global singleton OptBisect instead

Dec 11 2020, 7:06 PM · Restricted Project, Restricted Project

Dec 8 2020

swamulism requested review of D92897: Make NPM OptBisectInstrumentation use global singleton OptBisect .
Dec 8 2020, 4:38 PM · Restricted Project, Restricted Project