This is an archive of the discontinued LLVM Phabricator instance.

[MSAN] mark test as unsupported for powerpc.
AbandonedPublic

Authored by kda on Jun 8 2022, 5:06 PM.

Details

Reviewers
vitalybuka
Summary

The PowerPC implementation seems to return EINVAL (22) for pthread_getaffinity_np.
Without access to source code, it is hard to know why, as parameters appear to be valid.

Drops changes added in these commits:
https://reviews.llvm.org/D127359
https://reviews.llvm.org/D127346
https://reviews.llvm.org/D127320

Depends on: https://reviews.llvm.org/D127327

Diff Detail

Event Timeline

kda created this revision.Jun 8 2022, 5:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 5:06 PM
kda requested review of this revision.Jun 8 2022, 5:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 5:06 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka added inline comments.Jun 8 2022, 5:25 PM
compiler-rt/test/sanitizer_common/TestCases/Linux/pthread_getaffinity_np.cpp
9

typo

9

"no access to source code" -> "no access to the bot"?

code should be just regular glibc

vitalybuka accepted this revision.Jun 8 2022, 5:25 PM
This revision is now accepted and ready to land.Jun 8 2022, 5:25 PM
MaskRay added a subscriber: MaskRay.Jun 8 2022, 5:54 PM
MaskRay added inline comments.
compiler-rt/test/sanitizer_common/TestCases/Linux/pthread_getaffinity_np.cpp
9

I tested this. It passed on a 5.10.0-14-powerpc64le kernel. Do you have a link to the failure?

These are running on a machine that has 1536 CPUs:

$ lscpu
Architecture:        ppc64le
Byte Order:          Little Endian
CPU(s):              1536
On-line CPU(s) list: 0-1535
Thread(s) per core:  8
Core(s) per socket:  12
Socket(s):           16
NUMA node(s):        16

and the man page mentions:
EINVAL (pthread_getaffinity_np()) cpusetsize is smaller than the size of the affinity mask used by the kernel.
Could that have something to do with it?

These are running on a machine that has 1536 CPUs:

$ lscpu
Architecture:        ppc64le
Byte Order:          Little Endian
CPU(s):              1536
On-line CPU(s) list: 0-1535
Thread(s) per core:  8
Core(s) per socket:  12
Socket(s):           16
NUMA node(s):        16

and the man page mentions:
EINVAL (pthread_getaffinity_np()) cpusetsize is smaller than the size of the affinity mask used by the kernel.
Could that have something to do with it?

I read a bit of Linux kernel code. D127368 should have fixed the test :)

kda added a comment.Jun 8 2022, 10:28 PM

@MaskRay @nemanjai : Thanks for all the help. I'm dropping this.

kda abandoned this revision.Jun 8 2022, 10:32 PM