Page MenuHomePhabricator
Differential D127171

[DWARF] Support 'G' in dwarf parser
ClosedPublic
Actions

Authored by fmayer on Jun 6 2022, 5:57 PM.

Details

Reviewers
MaskRay
Commits
rGa2695c3fe1b7: [DWARF] Support 'G' in dwarf parser
rG4c71c3386c5c: [DWARF] Support 'G' in dwarf parser

Diff Detail

Unit TestsFailed
View All

TimeTest
60,070 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=thread -Wall -m64 -msse4.2 -gline-tables-only -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -std=c++11 -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -O1 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/restore_stack.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/restore_stack.cpp.tmp && not /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/restore_stack.cpp.tmp 2>&1 | FileCheck /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/restore_stack.cpp

Event Timeline

fmayer created this revision.Jun 6 2022, 5:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 5:57 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
fmayer requested review of this revision.Jun 6 2022, 5:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 5:57 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
fmayer mentioned this in D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.Jun 6 2022, 5:58 PM
fmayer updated this revision to Diff 434660.Jun 6 2022, 5:59 PM

test

fmayer mentioned this in D127148: [ELF] Support 'G' in .eh_frame.Jun 6 2022, 6:06 PM
fmayer added a reviewer: MaskRay.
Herald added a subscriber: StephenFan. · View Herald TranscriptJun 6 2022, 6:07 PM
fmayer added a parent revision: D127007: [MC] Add 'G' to augmentation string for MTE instrumented functions.Jun 6 2022, 6:15 PM
Harbormaster completed remote builds in B168195: Diff 434660.Jun 6 2022, 6:43 PM
MaskRay accepted this revision.Jun 6 2022, 7:30 PM

LGTM.

llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s
2

Use an generic ELF target triple to indicate that this does not need Linux features.

3

llvm-dwarfdump --eh-frame %t.o

20

Remove

This revision is now accepted and ready to land.Jun 6 2022, 7:30 PM
MaskRay added inline comments.Jun 6 2022, 7:30 PM
llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
1144

Can reuse break attached to case 'B'

fmayer updated this revision to Diff 434925.Jun 7 2022, 1:18 PM

address comments

fmayer added inline comments.Jun 7 2022, 1:20 PM
llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
1144

Is that actually worth saving one line for potential confusion down the line if anyone were ever to add anything to one of those?

fmayer marked 3 inline comments as done.Jun 7 2022, 1:23 PM
fmayer updated this revision to Diff 434928.Jun 7 2022, 1:24 PM

test

fmayer added a subscriber: eugenis.Jun 7 2022, 1:37 PM
MaskRay accepted this revision.Jun 7 2022, 1:45 PM
MaskRay added inline comments.
llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s
19

Delete comments like // -- End function

fmayer updated this revision to Diff 434942.Jun 7 2022, 1:57 PM

address comment

fmayer marked an inline comment as done.Jun 7 2022, 1:58 PM
Harbormaster completed remote builds in B168398: Diff 434942.Jun 7 2022, 3:10 PM
This revision was landed with ongoing or failed builds.Jun 8 2022, 12:39 PM
Closed by commit rG4c71c3386c5c: [DWARF] Support 'G' in dwarf parser (authored by fmayer). · Explain Why
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rG4c71c3386c5c: [DWARF] Support 'G' in dwarf parser.
fmayer added a reverting change: rG0d54a874ee24: Revert "[DWARF] Support 'G' in dwarf parser".Jun 8 2022, 1:53 PM
fmayer reopened this revision.Jun 8 2022, 1:53 PM

Tests broke on windows.

This revision is now accepted and ready to land.Jun 8 2022, 1:53 PM
fmayer updated this revision to Diff 435326.Jun 8 2022, 2:21 PM

require aarch64-registered-target

This revision was landed with ongoing or failed builds.Jun 8 2022, 2:28 PM
Closed by commit rGa2695c3fe1b7: [DWARF] Support 'G' in dwarf parser (authored by fmayer). · Explain Why
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rGa2695c3fe1b7: [DWARF] Support 'G' in dwarf parser.
Harbormaster completed remote builds in B168679: Diff 435326.Jun 8 2022, 3:11 PM

Revision Contents
Changeset List

PathSize
llvm/
lib/
DebugInfo/
DWARF/
4 lines
test/
DebugInfo/
AArch64/
16 lines

Diff 434942

View Options

llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

Loading...
View Options

llvm/test/DebugInfo/AArch64/stack-tagging-cfi.s

Loading...