This is an archive of the discontinued LLVM Phabricator instance.

[CMake][compiler-rt] Provide a dedicated option for LLVM unwinder
AbandonedPublic

Authored by phosek on Jun 2 2022, 12:53 PM.

Details

Summary

This allows configuring LLVM unwinder separately from the C++ library
matching how we configure it in libcxx.

Diff Detail

Event Timeline

phosek created this revision.Jun 2 2022, 12:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 12:53 PM
phosek requested review of this revision.Jun 2 2022, 12:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 12:53 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
mstorsjo accepted this revision.Jun 2 2022, 1:08 PM

This LGTM (although it would probably be easier to reason about if merged with the other patch).

Libcxx seems to maybe be moving to a different style of option for requesting linking e.g. libcxxabi statically, but I'm not sure if it's worth (or even feasible) to try to align this option with the suggested new libcxx option format.

This revision is now accepted and ready to land.Jun 2 2022, 1:08 PM
phosek abandoned this revision.Jun 13 2022, 12:20 PM

Merged into D115674.