This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Add an install target for mlir-libraries
ClosedPublic

Authored by lanza on Jun 1 2022, 3:55 PM.

Details

Summary

This is required for the distribution system for installing the
mlir-libraries component. This is copied from clang's equivalent
feature.

Diff Detail

Event Timeline

lanza created this revision.Jun 1 2022, 3:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2022, 3:55 PM
lanza requested review of this revision.Jun 1 2022, 3:55 PM
smeenai added inline comments.
mlir/CMakeLists.txt
231

This should be MLIR_LIBS, right?

smeenai requested changes to this revision.Jun 2 2022, 3:43 PM

Putting back in your queue to address the comment.

This revision now requires changes to proceed.Jun 2 2022, 3:43 PM
lanza requested review of this revision.Jun 7 2022, 7:47 PM
lanza marked an inline comment as done.
lanza added inline comments.
mlir/CMakeLists.txt
231
smeenai added inline comments.Jun 7 2022, 7:48 PM
mlir/CMakeLists.txt
231

Right, but right above this you're doing a get_property into the MLIR_LIBS variable.

lanza marked an inline comment as done.Jun 7 2022, 7:52 PM
lanza added inline comments.
mlir/CMakeLists.txt
231

Oh, duh, good eye :p

lanza updated this revision to Diff 435033.Jun 7 2022, 7:55 PM

Fix typo

smeenai accepted this revision.Jun 7 2022, 7:56 PM

LGTM

This revision is now accepted and ready to land.Jun 7 2022, 7:56 PM
This revision was landed with ongoing or failed builds.Jun 7 2022, 7:57 PM
This revision was automatically updated to reflect the committed changes.