Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Making this a Diff mostly because it changes (although non-functionally) such a huge file.
I don't know how people feel nowadays about clang-formatting an entire file.
In the past, we used to only format around local changes and hope that, in time, it would converge.
The bad side of formatting everything is that git-blame needs one more level of indirection. It's not terrible, though.
I'd ask other people around how they still feel about it. I don't personally mind, but I also don't personally work on this file often.
Adding the top five people blamed for changed lines in 2022 as reviewers.. Are you okay with auto-formatting the whole file with one commit?
#lines_blamed_in_2022 Name --------------------------------------------- 79 Philip Reames 69 Nikita Popov 61 Florian Hahn 37 Sanjay Patel 31 Hirochika Matsumoto 20 Kevin P. Neal 10 Roman Lebedev 9 Serge Pavlov 5 Nuno Lopes
LGTM - I'd go further and update the old "FunctionName" formatting too, so we are consistent with the current "functionName" style.
Many of the changed lines would already overlap, and if it's done in this patch, then that's still just this one potential commit that anyone would be looking past with 'blame'.