[MLIR][Presburger] Move Matrix accessors inline

[arjunp]

Summary

This gives a 1.5x speedup on the Presburger unittests.

[arjunp]

format

[Groverkss]

One minor comment. Rest, LGTM.

mlir/include/mlir/Analysis/Presburger/Matrix.h

75–82

Could you also make these trivial functions inline?

mlir/include/mlir/Analysis/Presburger/Matrix.h

public:
   /// Initially, the entries are initialized to ero.
   Matrix(unsigned rows, unsigned columns, unsigned reservedRows = 0,
          unsigned reservedColumns = 0);
 
   /// Return the identity matrix of the specified dimension.
   static Matrix identity(unsigned dimension);
 
   /// Access the element at the specified row and column.
-  int64_t &at(unsigned row, unsigned column);
-  int64_t at(unsigned row, unsigned column) const;
-  int64_t &operator()(unsigned row, unsigned column);
-  int64_t operator()(unsigned row, unsigned column) const;
+  int64_t &at(unsigned row, unsigned column) {
+    assert(row < nRows && "Row outside of range");
+    assert(column < nColumns && "Column outside of range");
+    return data[row * nReservedColumns + column];
+  }
+
+  int64_t at(unsigned row, unsigned column) const {
+    assert(row < nRows && "Row outside of range");
+    assert(column < nColumns && "Column outside of range");
+    return data[row * nReservedColumns + column];
+  }
+
+  int64_t &operator()(unsigned row, unsigned column) { return at(row, column); }
+
+  int64_t operator()(unsigned row, unsigned column) const {
+    return at(row, column);
+  }
 
   /// Swap the given columns.
   void swapColumns(unsigned column, unsigned otherColumn);
 
   /// Swap the given rows.
   void swapRows(unsigned row, unsigned otherRow);
 
   unsigned getNumRows() const;
 
   unsigned getNumColumns() const;
 
   /// Return the maximum number of rows/columns that can be added without
   /// incurring a reallocation.
   unsigned getNumReservedRows() const;
   unsigned getNumReservedColumns() const;
 
   /// Reserve enough space to resize to the specified number of rows without
   /// reallocations.
   void reserveRows(unsigned rows);
 
   /// Get a [Mutable]ArrayRef corresponding to the specified row.
   MutableArrayRef<int64_t> getRow(unsigned row);
   ArrayRef<int64_t> getRow(unsigned row) const;

mlir/lib/Analysis/Presburger/Matrix.cpp

 
 Matrix Matrix::identity(unsigned dimension) {
   Matrix matrix(dimension, dimension);
   for (unsigned i = 0; i < dimension; ++i)
     matrix(i, i) = 1;
   return matrix;
 }
 
-int64_t &Matrix::at(unsigned row, unsigned column) {
-  assert(row < nRows && "Row outside of range");
-  assert(column < nColumns && "Column outside of range");
-  return data[row * nReservedColumns + column];
-}
-
-int64_t Matrix::at(unsigned row, unsigned column) const {
-  assert(row < nRows && "Row outside of range");
-  assert(column < nColumns && "Column outside of range");
-  return data[row * nReservedColumns + column];
-}
-
-int64_t &Matrix::operator()(unsigned row, unsigned column) {
-  return at(row, column);
-}
-
-int64_t Matrix::operator()(unsigned row, unsigned column) const {
-  return at(row, column);
-}
-
 unsigned Matrix::getNumRows() const { return nRows; }
 
 unsigned Matrix::getNumColumns() const { return nColumns; }
 
 unsigned Matrix::getNumReservedColumns() const { return nReservedColumns; }
 
 unsigned Matrix::getNumReservedRows() const {
   return data.capacity() / nReservedColumns;