Page MenuHomePhabricator

[mlir][TableGen][NFC] Compact OpBase description
Needs ReviewPublic

Authored by javedabsar on May 27 2022, 7:55 AM.

Details

Summary

Make the OpBase tablgen descriptions shorter for easier read

Diff Detail

Event Timeline

javedabsar created this revision.May 27 2022, 7:55 AM
javedabsar requested review of this revision.May 27 2022, 7:55 AM
jpienaar added inline comments.
mlir/include/mlir/IR/OpBase.td
104

This decreases readability for me, these aren't instances of a parameterized base class but separate atoms that share a prefix.

rriddle requested changes to this revision.Fri, May 27, 11:32 AM
rriddle added inline comments.
mlir/include/mlir/IR/OpBase.td
104

Same kind of applies to me in all of these changes. Seems like this is trading off a small amount of code line decrease for much less readability.

This revision now requires changes to proceed.Fri, May 27, 11:32 AM

Fix based on review comments

I have removed parts that reduced readibility. The ones left are like what would be common in llvm td files.
But if you reckon this doesnt help readability its ok i will abandon the diff.

javedabsar marked 2 inline comments as done.Sat, May 28, 5:20 AM

Is none of these changes desirable ? If so I will abandon this diff.