Page MenuHomePhabricator

Fix lldb-vscode frame test failure
ClosedPublic

Authored by yinghuitan on May 23 2022, 10:21 AM.

Details

Summary

Previous patch (https://reviews.llvm.org/D126013) added a new "optimized"
attribute to DAP stack frame this caused some tests, like
lldb-vscode/coreFile/TestVSCode_coreFile.py
to fail because the tests explicitly check for all attributes.

To fix the test failure I decided to remove this attribute.

Diff Detail

Event Timeline

yinghuitan created this revision.May 23 2022, 10:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 10:21 AM
yinghuitan requested review of this revision.May 23 2022, 10:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 10:21 AM
clayborg accepted this revision.May 23 2022, 1:03 PM

Since this "optimized" value isn't part of the actual JSON schema for the stack frames, and since we aren't using it in the IDE, best to remove this until it is either in the protocol definition or used by the IDE.

This revision is now accepted and ready to land.May 23 2022, 1:03 PM
This revision was automatically updated to reflect the committed changes.