[MIR] Provide location of extra instruction operand when diagnosing it.

[kosarev]

Summary

Also resolves misspelled FileCheck directives caught with D125604.

[foad]

LGTM, thanks!

llvm/lib/CodeGen/MIRParser/MIParser.cpp

bool MIParser::parse(MachineInstr *&MI) {
   MI->setFlags(Flags);
 
   unsigned NumExplicitOps = 0;
   for (const auto &Operand : Operands) {
     bool IsImplicitOp = Operand.Operand.isReg() && Operand.Operand.isImplicit();
     if (!IsImplicitOp) {
       if (!MCID.isVariadic() && NumExplicitOps >= MCID.getNumOperands() &&
           !Operand.Operand.isValidExcessOperand())
-        return error("too many operands for instruction");
+        return error(Operand.Begin, "too many operands for instruction");
 
       ++NumExplicitOps;
     }
 
     MI->addOperand(MF, Operand.Operand);
   }
 
   if (assignRegisterTies(*MI, Operands))

llvm/test/CodeGen/MIR/AMDGPU/extra-imm-operand.mir

-# RUN: not llc -march=amdgcn -run-pass=none -o /dev/null %s 2>&1 | FileCheck %s
+# RUN: not llc -march=amdgcn -run-pass=none -o /dev/null %s 2>&1 | \
+# RUN:   FileCheck --strict-whitespace %s
 
 ---
 name: extra_imm_operand
 body: |
   bb.0:
-    ; CHECK: [[@LINE+3]]:18: too many operands for instruction
-    ; CHECK-NEXT: S_ENDPGM 0, 0
-    ; CHECK_NEXT:               ^
+    ; CHECK: [[@LINE+3]]:17: too many operands for instruction
+    ; CHECK-NEXT: {{^}}    S_ENDPGM 0, 0
+    ; CHECK-NEXT: {{^}}                ^
     S_ENDPGM 0, 0
 
 ...

llvm/test/CodeGen/MIR/AMDGPU/extra-reg-operand.mir

-# RUN: not llc -march=amdgcn -run-pass=none -o /dev/null %s 2>&1 | FileCheck %s
+# RUN: not llc -march=amdgcn -run-pass=none -o /dev/null %s 2>&1 | \
+# RUN:   FileCheck --strict-whitespace %s
 
 ---
 name: extra_reg_operand
 body: |
   bb.0:
-    ; CHECK: [[@LINE+3]]:29: too many operands for instruction
-    ; S_ENDPGM 0, undef $vgpr0
-    ; CHECK_NEXT:               ^
+    ; CHECK: [[@LINE+3]]:17: too many operands for instruction
+    ; CHECK-NEXT: {{^}}    S_ENDPGM 0, undef $vgpr0
+    ; CHECK-NEXT: {{^}}                ^
     S_ENDPGM 0, undef $vgpr0
 
 ...