This is an archive of the discontinued LLVM Phabricator instance.

[M68k] Fix decoding conflict between move instructions and their tail call version
ClosedPublic

Authored by 0x59616e on May 18 2022, 11:22 PM.

Details

Summary

This diff resolves the the remaining decoding conflict that occurs when you build M68k backend.

Diff Detail

Event Timeline

0x59616e created this revision.May 18 2022, 11:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 11:22 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
0x59616e requested review of this revision.May 18 2022, 11:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 11:22 PM
0x59616e planned changes to this revision.May 18 2022, 11:25 PM
0x59616e retitled this revision from Fix decoding conflict between move instructions and their tail call version to [M68k] Fix decoding conflict between move instructions and their tail call version.
0x59616e edited the summary of this revision. (Show Details)
0x59616e added reviewers: myhsu, ricky26, RKSimon.

Didn't notice some test were failed.

0x59616e updated this revision to Diff 430582.May 18 2022, 11:31 PM

Fix failed test

myhsu accepted this revision.May 21 2022, 6:03 PM

LGTM. Thanks for fixing it.
Large portion of this patch seems to be additional tests for MOVE. Can you split them into a separate commit? (no need to create another Phab review, I've reviewed those test cases)

This revision is now accepted and ready to land.May 21 2022, 6:03 PM

Thanks for reviewing ;)

LGTM. Thanks for fixing it.
Large portion of this patch seems to be additional tests for MOVE. Can you split them into a separate commit? (no need to create another Phab review, I've reviewed those test cases)

Sure !

This revision was landed with ongoing or failed builds.May 21 2022, 7:35 PM
This revision was automatically updated to reflect the committed changes.