This is an archive of the discontinued LLVM Phabricator instance.

Differential D125935

Fix if statement in DebugInfo/GSYM/LookupResult.cpp
ClosedPublic

Authored by apivovarov on May 18 2022, 4:10 PM.

Details

Reviewers
clayborg
Summary

Fix if statement in DebugInfo/GSYM/LookupResult.cpp. Use "&& !" instead of "and not"

Diff Detail

Unit TestsFailed

TimeTest
60,130 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,050 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

apivovarov created this revision.May 18 2022, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 4:10 PM
Herald added subscribers: StephenFan, hiraditya. · View Herald Transcript
apivovarov requested review of this revision.May 18 2022, 4:10 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptMay 18 2022, 4:10 PM
clayborg accepted this revision.May 18 2022, 4:59 PM
This revision is now accepted and ready to land.May 18 2022, 4:59 PM
Harbormaster completed remote builds in B165226: Diff 430526.May 18 2022, 5:04 PM
apivovarov removed reviewers: MaskRay, RKSimon, serge-sans-paille.May 18 2022, 10:52 PM
apivovarov closed this revision.May 18 2022, 10:54 PM

Closed by commit b21c03854cee200c1ea9d693a4daf9cf06408f14 Fix if statement in DebugInfo/GSYM/LookupResult.cpp (committed by apivovarov)

Revision Contents

PathSize
llvm/
lib/
DebugInfo/
GSYM/
2 lines

Diff 430526

llvm/lib/DebugInfo/GSYM/LookupResult.cpp

Context not available.
OS << " @ "; OS << " @ ";
if (!SL.Dir.empty()) { if (!SL.Dir.empty()) {
OS << SL.Dir; OS << SL.Dir;
if (SL.Dir.contains('\\') and not SL.Dir.contains('/')) if (SL.Dir.contains('\\') && !SL.Dir.contains('/'))
OS << '\\'; OS << '\\';
else else
OS << '/'; OS << '/';
Context not available.