This is an archive of the discontinued LLVM Phabricator instance.

[fortran] Use flang-to-external-fc instead of flang

Authored by DavidSpickett on May 17 2022, 8:12 AM.



The bash script that was flang is now called flang-to-external-fc.

Event Timeline

DavidSpickett created this revision.May 17 2022, 8:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
DavidSpickett requested review of this revision.May 17 2022, 8:12 AM
DavidSpickett added inline comments.

And no this isn't going to be correct. I'm not sure that it ever was because no Windows flang bot runs the testsuite yet. No worse than before at least.

Makes sense (just need to update flang-to-gfortran to flang-to-external-fc and wait for D125832 to be merged. Thanks for doing this!


@kiranchandramohan Suggested that we use flang-to-external-fc instead. I've updated D125832 accordingly.

Use the new name.

DavidSpickett retitled this revision from [fortran] Use flang-to-gfortran instead of flang to [fortran] Use flang-to-external-fc instead of flang.May 18 2022, 7:57 AM
DavidSpickett edited the summary of this revision. (Show Details)
awarzynski accepted this revision.May 31 2022, 11:44 PM has been merged, so this is ready to land.

I know that clang-aarch64-full-2stage started failing after my change - not sure why :( But I suspect that this change will fix it. WDYT?

This revision is now accepted and ready to land.May 31 2022, 11:44 PM
DavidSpickett marked an inline comment as done.Jun 1 2022, 1:50 AM

If I'm not around to land this myself, go ahead then email Galina (address on this page to ask for a buildbot restart to include the change.

This is now present on the bots:

2022-06-06 05:50:50 INFO:   CMAKE_Fortran_COMPILER: '/home/tcwg-buildbot/worker/clang-aarch64-full-2stage/stage2.install/bin/flang-to-external-fc'

This is now present on the bots:

2022-06-06 05:50:50 INFO:   CMAKE_Fortran_COMPILER: '/home/tcwg-buildbot/worker/clang-aarch64-full-2stage/stage2.install/bin/flang-to-external-fc'

Great, we can get rid of flang then: